mirror of
https://github.com/torvalds/linux.git
synced 2026-04-25 01:52:32 -04:00
perf test: Change all remaining #!/bin/sh to #!/bin/bash
There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
committed by
Namhyung Kim
parent
f0d0f978f3
commit
2f5d370dec
@@ -85,7 +85,7 @@ static char *shell_test__description(int dir_fd, const char *name)
|
||||
if (io.fd < 0)
|
||||
return NULL;
|
||||
|
||||
/* Skip first line - should be #!/bin/sh Shebang */
|
||||
/* Skip first line - should be #!/bin/bash Shebang */
|
||||
if (io__get_char(&io) != '#')
|
||||
goto err_out;
|
||||
if (io__get_char(&io) != '!')
|
||||
|
||||
Reference in New Issue
Block a user