bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 23:03:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm: move drm based debugfs funcs to drm_debugfs.c

Browse Source 
Requirement is to create per client-id based directories to
hold key debugging information and for that access to
root debugfs dentry is need which is not in one place
and that information cannot be stored in drm_device.

Move the debugfs functionality from drm_drv.c and drm_accel.c
to drm_debugfs.c This enables debugfs root node reference
directly drm_debugfs.c and hence enable to create per client-id
directory.

v8: Create drm_accel dentry only if it's config is enabled (Jeff, Hugo)
v8: Merge drm_drv and drm_accel debugfs patches (Koenig, Christian)

v10: Since we moved drm_debugfs_root, hence to handle drm bridge
debugfs add a new function which call drm_bridge_debugfs_params where
drm_debugfs_root is accessible.

Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Link: https://lore.kernel.org/r/20250704075548.1549849-2-sunil.khatri@amd.com
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
This commit is contained in:
Sunil Khatri
2025-07-04 13:25:45 +05:30
committed by Christian König
parent 9cbc40521b
commit 348fe34a61
6 changed files with 55 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
drivers/gpu/drm/drm_debugfs.c
View File

@@ -44,6 +44,9 @@
#include "drm_crtc_internal.h"
#include "drm_internal.h"
static struct dentry *accel_debugfs_root;
static struct dentry *drm_debugfs_root;
/***************************************************
* Initialization, etc.
**************************************************/
@@ -287,16 +290,39 @@ int drm_debugfs_remove_files(const struct drm_info_list *files, int count,
}
EXPORT_SYMBOL(drm_debugfs_remove_files);
void drm_debugfs_bridge_params(void)
{
drm_bridge_debugfs_params(drm_debugfs_root);
}
void drm_debugfs_init_root(void)
{
drm_debugfs_root = debugfs_create_dir("dri", NULL);
#if IS_ENABLED(CONFIG_DRM_ACCEL)
accel_debugfs_root = debugfs_create_dir("accel", NULL);
#endif
}
void drm_debugfs_remove_root(void)
{
#if IS_ENABLED(CONFIG_DRM_ACCEL)
debugfs_remove(accel_debugfs_root);
#endif
debugfs_remove(drm_debugfs_root);
}
/**
* drm_debugfs_dev_init - create debugfs directory for the device
* @dev: the device which we want to create the directory for
* @root: the parent directory depending on the device type
*
* Creates the debugfs directory for the device under the given root directory.
*/
void drm_debugfs_dev_init(struct drm_device *dev, struct dentry *root)
void drm_debugfs_dev_init(struct drm_device *dev)
{
dev->debugfs_root = debugfs_create_dir(dev->unique, root);
if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL))
dev->debugfs_root = debugfs_create_dir(dev->unique, accel_debugfs_root);
else
dev->debugfs_root = debugfs_create_dir(dev->unique, drm_debugfs_root);
}
/**
@@ -323,14 +349,13 @@ void drm_debugfs_dev_register(struct drm_device *dev)
drm_atomic_debugfs_init(dev);
}
int drm_debugfs_register(struct drm_minor *minor, int minor_id,
struct dentry *root)
int drm_debugfs_register(struct drm_minor *minor, int minor_id)
{
struct drm_device *dev = minor->dev;
char name[64];
sprintf(name, "%d", minor_id);
minor->debugfs_symlink = debugfs_create_symlink(name, root,
minor->debugfs_symlink = debugfs_create_symlink(name, drm_debugfs_root,
dev->unique);
/* TODO: Only for compatibility with drivers */