bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

mm: vmalloc: update outdated comment for renamed vread()

Browse Source 
The function vread() was renamed to vread_iter() in commit 4c91c07c93
("mm: vmalloc: convert vread() to vread_iter()"), converting from a
buffer-based to an iterator-based interface.

Update the kdoc of vread_iter() to reflect the new interface: replace
references to @buf with @iter, drop the stale "kernel's buffer"
requirement, and update the self-reference from vread() to vread_iter().

Also update the stale vread() reference in pstore's ram_core.c.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Link: https://lkml.kernel.org/r/20260321105820.7134-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Julia Lawall <julia.lawall@inria.fr>
Cc: Kees Cook <kees@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Kexin Sun
2026-03-21 18:58:20 +08:00
committed by Andrew Morton
parent c4a9439a5a
commit 3cb0dc0d0e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/pstore/ram_core.c
View File

@@ -450,7 +450,7 @@ static void *persistent_ram_vmap(phys_addr_t start, size_t size,
pages[i] = pfn_to_page(addr >> PAGE_SHIFT); pages[i] = pfn_to_page(addr >> PAGE_SHIFT);
} }
/* /*
* VM_IOREMAP used here to bypass this region during vread() * VM_IOREMAP used here to bypass this region during vread_iter()
* and kmap_atomic() (i.e. kcore) to avoid __va() failures. * and kmap_atomic() (i.e. kcore) to avoid __va() failures.
*/ */
vaddr = vmap(pages, page_count, VM_MAP | VM_IOREMAP, prot); vaddr = vmap(pages, page_count, VM_MAP | VM_IOREMAP, prot);

10
mm/vmalloc.c
View File

@@ -4575,20 +4575,20 @@ finished:
* @count: number of bytes to be read. * @count: number of bytes to be read.
* *
* This function checks that addr is a valid vmalloc'ed area, and * This function checks that addr is a valid vmalloc'ed area, and
* copy data from that area to a given buffer. If the given memory range * copies data from that area to a given iterator. If the given memory range
* of [addr...addr+count) includes some valid address, data is copied to * of [addr...addr+count) includes some valid address, data is copied to
* proper area of @buf. If there are memory holes, they'll be zero-filled. * proper area of @iter. If there are memory holes, they'll be zero-filled.
* IOREMAP area is treated as memory hole and no copy is done. * IOREMAP area is treated as memory hole and no copy is done.
* *
* If [addr...addr+count) doesn't includes any intersects with alive * If [addr...addr+count) doesn't includes any intersects with alive
* vm_struct area, returns 0. @buf should be kernel's buffer. * vm_struct area, returns 0.
* *
* Note: In usual ops, vread() is never necessary because the caller * Note: In usual ops, vread_iter() is never necessary because the caller
* should know vmalloc() area is valid and can use memcpy(). * should know vmalloc() area is valid and can use memcpy().
* This is for routines which have to access vmalloc area without * This is for routines which have to access vmalloc area without
* any information, as /proc/kcore. * any information, as /proc/kcore.
* *
* Return: number of bytes for which addr and buf should be increased * Return: number of bytes for which addr and iter should be advanced
* (same number as @count) or %0 if [addr...addr+count) doesn't * (same number as @count) or %0 if [addr...addr+count) doesn't
* include any intersection with valid vmalloc area * include any intersection with valid vmalloc area
*/ */