bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked()

Browse Source 
IBI disable failures are not indicative of a software bug, so using
WARN_ON() is not appropriate.  Replace these warnings with dev_err().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260113072702.16268-5-adrian.hunter@intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Adrian Hunter
2026-01-13 09:26:45 +02:00
committed by Alexandre Belloni
parent f0775157b9
commit 471895799c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/i3c/master.c
View File

@@ -3150,8 +3150,11 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev)
if (!dev->ibi)
return;
if (WARN_ON(dev->ibi->enabled))
WARN_ON(i3c_dev_disable_ibi_locked(dev));
if (dev->ibi->enabled) {
dev_err(&master->dev, "Freeing IBI that is still enabled\n");
if (i3c_dev_disable_ibi_locked(dev))
dev_err(&master->dev, "Failed to disable IBI before freeing\n");
}
master->ops->free_ibi(dev);