bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

sed-opal: Add STACK_RESET command

Browse Source 
The TCG Opal device could enter a state where no new session can be
created, blocking even Discovery or PSID reset. While a power cycle
or waiting for the timeout should work, there is another possibility
for recovery: using the Stack Reset command.

The Stack Reset command is defined in the TCG Storage Architecture Core
Specification and is mandatory for all Opal devices (see Section 3.3.6
of the Opal SSC specification).

This patch implements the Stack Reset command. Sending it should clear
all active sessions immediately, allowing subsequent commands to run
successfully. While it is a TCG transport layer command, the Linux
kernel implements only Opal ioctls, so it makes sense to use the
IOC_OPAL ioctl interface.

The Stack Reset takes no arguments; the response can be success or pending.
If the command reports a pending state, userspace can try to repeat it;
in this case, the code returns -EBUSY.

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Ondrej Kozina <okozina@redhat.com>
Link: https://patch.msgid.link/20260310095349.411287-1-gmazyland@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Milan Broz
2026-03-10 10:53:49 +01:00
committed by Jens Axboe
parent 75e75445b9
commit 499d2d2f4c
4 changed files with 69 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
block/sed-opal.c
View File

@@ -3545,6 +3545,50 @@ static int opal_get_sum_ranges(struct opal_dev *dev, struct opal_sum_ranges *opa
return ret;
}
static int opal_stack_reset(struct opal_dev *dev)
{
struct opal_stack_reset *req;
struct opal_stack_reset_response *resp;
int ret;
mutex_lock(&dev->dev_lock);
memset(dev->cmd, 0, IO_BUFFER_LENGTH);
req = (struct opal_stack_reset *)dev->cmd;
req->extendedComID[0] = dev->comid >> 8;
req->extendedComID[1] = dev->comid & 0xFF;
req->request_code = cpu_to_be32(OPAL_STACK_RESET);
ret = dev->send_recv(dev->data, dev->comid, TCG_SECP_02,
dev->cmd, IO_BUFFER_LENGTH, true);
if (ret) {
pr_debug("Error sending stack reset: %d\n", ret);
goto out;
}
memset(dev->resp, 0, IO_BUFFER_LENGTH);
ret = dev->send_recv(dev->data, dev->comid, TCG_SECP_02,
dev->resp, IO_BUFFER_LENGTH, false);
if (ret) {
pr_debug("Error receiving stack reset response: %d\n", ret);
goto out;
}
resp = (struct opal_stack_reset_response *)dev->resp;
if (be16_to_cpu(resp->data_length) != 4) {
pr_debug("Stack reset pending\n");
ret = -EBUSY;
goto out;
}
if (be32_to_cpu(resp->response) != 0) {
pr_debug("Stack reset failed: %u\n", be32_to_cpu(resp->response));
ret = -EIO;
}
out:
mutex_unlock(&dev->dev_lock);
return ret;
}
int sed_ioctl(struct opal_dev *dev, unsigned int cmd, void __user *arg)
{
void *p;
@@ -3642,6 +3686,9 @@ int sed_ioctl(struct opal_dev *dev, unsigned int cmd, void __user *arg)
case IOC_OPAL_GET_SUM_STATUS:
ret = opal_get_sum_ranges(dev, p, arg);
break;
case IOC_OPAL_STACK_RESET:
ret = opal_stack_reset(dev);
break;
default:
break;