mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
drm/i915: make intel_wakeref work on the rpm struct
intel_runtime_pm is the only thing they use from the i915 structure, so use that directly. Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20190613232156.34940-9-daniele.ceraolospurio@intel.com
This commit is contained in:
committed by
Chris Wilson
parent
c447ff7db3
commit
58a111f03a
@@ -4,23 +4,23 @@
|
||||
* Copyright © 2019 Intel Corporation
|
||||
*/
|
||||
|
||||
#include "intel_drv.h"
|
||||
#include "intel_wakeref.h"
|
||||
#include "intel_runtime_pm.h"
|
||||
#include "i915_gem.h"
|
||||
|
||||
static void rpm_get(struct drm_i915_private *i915, struct intel_wakeref *wf)
|
||||
static void rpm_get(struct intel_runtime_pm *rpm, struct intel_wakeref *wf)
|
||||
{
|
||||
wf->wakeref = intel_runtime_pm_get(&i915->runtime_pm);
|
||||
wf->wakeref = intel_runtime_pm_get(rpm);
|
||||
}
|
||||
|
||||
static void rpm_put(struct drm_i915_private *i915, struct intel_wakeref *wf)
|
||||
static void rpm_put(struct intel_runtime_pm *rpm, struct intel_wakeref *wf)
|
||||
{
|
||||
intel_wakeref_t wakeref = fetch_and_zero(&wf->wakeref);
|
||||
|
||||
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
|
||||
intel_runtime_pm_put(rpm, wakeref);
|
||||
GEM_BUG_ON(!wakeref);
|
||||
}
|
||||
|
||||
int __intel_wakeref_get_first(struct drm_i915_private *i915,
|
||||
int __intel_wakeref_get_first(struct intel_runtime_pm *rpm,
|
||||
struct intel_wakeref *wf,
|
||||
int (*fn)(struct intel_wakeref *wf))
|
||||
{
|
||||
@@ -34,11 +34,11 @@ int __intel_wakeref_get_first(struct drm_i915_private *i915,
|
||||
if (!atomic_read(&wf->count)) {
|
||||
int err;
|
||||
|
||||
rpm_get(i915, wf);
|
||||
rpm_get(rpm, wf);
|
||||
|
||||
err = fn(wf);
|
||||
if (unlikely(err)) {
|
||||
rpm_put(i915, wf);
|
||||
rpm_put(rpm, wf);
|
||||
mutex_unlock(&wf->mutex);
|
||||
return err;
|
||||
}
|
||||
@@ -51,7 +51,7 @@ int __intel_wakeref_get_first(struct drm_i915_private *i915,
|
||||
return 0;
|
||||
}
|
||||
|
||||
int __intel_wakeref_put_last(struct drm_i915_private *i915,
|
||||
int __intel_wakeref_put_last(struct intel_runtime_pm *rpm,
|
||||
struct intel_wakeref *wf,
|
||||
int (*fn)(struct intel_wakeref *wf))
|
||||
{
|
||||
@@ -59,7 +59,7 @@ int __intel_wakeref_put_last(struct drm_i915_private *i915,
|
||||
|
||||
err = fn(wf);
|
||||
if (likely(!err))
|
||||
rpm_put(i915, wf);
|
||||
rpm_put(rpm, wf);
|
||||
else
|
||||
atomic_inc(&wf->count);
|
||||
mutex_unlock(&wf->mutex);
|
||||
@@ -86,17 +86,17 @@ static void wakeref_auto_timeout(struct timer_list *t)
|
||||
wakeref = fetch_and_zero(&wf->wakeref);
|
||||
spin_unlock_irqrestore(&wf->lock, flags);
|
||||
|
||||
intel_runtime_pm_put(&wf->i915->runtime_pm, wakeref);
|
||||
intel_runtime_pm_put(wf->rpm, wakeref);
|
||||
}
|
||||
|
||||
void intel_wakeref_auto_init(struct intel_wakeref_auto *wf,
|
||||
struct drm_i915_private *i915)
|
||||
struct intel_runtime_pm *rpm)
|
||||
{
|
||||
spin_lock_init(&wf->lock);
|
||||
timer_setup(&wf->timer, wakeref_auto_timeout, 0);
|
||||
refcount_set(&wf->count, 0);
|
||||
wf->wakeref = 0;
|
||||
wf->i915 = i915;
|
||||
wf->rpm = rpm;
|
||||
}
|
||||
|
||||
void intel_wakeref_auto(struct intel_wakeref_auto *wf, unsigned long timeout)
|
||||
@@ -110,13 +110,13 @@ void intel_wakeref_auto(struct intel_wakeref_auto *wf, unsigned long timeout)
|
||||
}
|
||||
|
||||
/* Our mission is that we only extend an already active wakeref */
|
||||
assert_rpm_wakelock_held(&wf->i915->runtime_pm);
|
||||
assert_rpm_wakelock_held(wf->rpm);
|
||||
|
||||
if (!refcount_inc_not_zero(&wf->count)) {
|
||||
spin_lock_irqsave(&wf->lock, flags);
|
||||
if (!refcount_inc_not_zero(&wf->count)) {
|
||||
GEM_BUG_ON(wf->wakeref);
|
||||
wf->wakeref = intel_runtime_pm_get_if_in_use(&wf->i915->runtime_pm);
|
||||
wf->wakeref = intel_runtime_pm_get_if_in_use(wf->rpm);
|
||||
refcount_set(&wf->count, 1);
|
||||
}
|
||||
spin_unlock_irqrestore(&wf->lock, flags);
|
||||
|
||||
Reference in New Issue
Block a user