mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 14:53:58 -04:00
rust: enable clippy::as_underscore lint
In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > The conversion might include lossy conversion or a dangerous cast that > might go undetected due to the type being inferred. > > The lint is allowed by default as using `_` is less wordy than always > specifying the type. Always specifying the type is especially helpful in function call contexts where the inferred type may change at a distance. Specifying the type also allows Clippy to spot more cases of `useless_conversion`. The primary downside is the need to specify the type in trivial getters. There are 4 such functions: 3 have become slightly less ergonomic, 1 was revealed to be a `useless_conversion`. While this doesn't eliminate unchecked `as` conversions, it makes such conversions easier to scrutinize. It also has the slight benefit of removing a degree of freedom on which to bikeshed. Thus apply the changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_underscore [1] Reviewed-by: Benno Lossin <benno.lossin@proton.me> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Signed-off-by: Tamir Duberstein <tamird@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Danilo Krummrich <dakr@kernel.org> Link: https://lore.kernel.org/r/20250615-ptr-as-ptr-v12-4-f43b024581e8@gmail.com [ Changed `isize` to `c_long`. - Miguel ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This commit is contained in:
committed by
Miguel Ojeda
parent
23773bd8da
commit
5e30550558
@@ -101,7 +101,7 @@ impl<T: Operations> OperationsVTable<T> {
|
||||
if let Err(e) = ret {
|
||||
e.to_blk_status()
|
||||
} else {
|
||||
bindings::BLK_STS_OK as _
|
||||
bindings::BLK_STS_OK as bindings::blk_status_t
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -125,7 +125,12 @@ impl<T: Operations> Request<T> {
|
||||
// success of the call to `try_set_end` guarantees that there are no
|
||||
// `ARef`s pointing to this request. Therefore it is safe to hand it
|
||||
// back to the block layer.
|
||||
unsafe { bindings::blk_mq_end_request(request_ptr, bindings::BLK_STS_OK as _) };
|
||||
unsafe {
|
||||
bindings::blk_mq_end_request(
|
||||
request_ptr,
|
||||
bindings::BLK_STS_OK as bindings::blk_status_t,
|
||||
)
|
||||
};
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user