mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 14:53:58 -04:00
kthread: Comment on the purpose and placement of kthread_affine_node() call
It may not appear obvious why kthread_affine_node() is not called before the kthread creation completion instead of after the first wake-up. The reason is that kthread_affine_node() applies a default affinity behaviour that only takes place if no affinity preference have already been passed by the kthread creation call site. Add a comment to clarify that. Reported-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Frederic Weisbecker <frederic@kernel.org> Cc: Marco Crivellari <marco.crivellari@suse.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Tejun Heo <tj@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Waiman Long <longman@redhat.com>
This commit is contained in:
@@ -453,6 +453,10 @@ static int kthread(void *_create)
|
||||
|
||||
self->started = 1;
|
||||
|
||||
/*
|
||||
* Apply default node affinity if no call to kthread_bind[_mask]() nor
|
||||
* kthread_affine_preferred() was issued before the first wake-up.
|
||||
*/
|
||||
if (!(current->flags & PF_NO_SETAFFINITY) && !self->preferred_affinity)
|
||||
kthread_affine_node();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user