bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

reset: don't overwrite fwnode_reset_n_cells

Browse Source 
Fix a logic bug in reset_controller_register() where we set
fwnode_reset_n_cells to 1 if fwnode is set and fwnode_xlate is not but
we do it after assigning of_fwnode_handle(of_node) to fwnode.

Modify the logic to: assign fwnode from of_node if applicable, if fwnode
is still not set, try to get it from the device and only then check
of_xlate and fwnode_xlate and either assign fwnode_reset_n_cells from OF
or default to fwnode_reset_simple_xlate and fwnode_reset_n_cells = 1.

Fixes: ba8dbbb14b ("reset: convert the core API to using firmware nodes")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/0b72286b-33dd-4bc9-8c0e-161c2f4baed8@sirena.org.uk/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tested-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Bartosz Golaszewski
2026-03-10 16:15:15 +01:00
committed by Philipp Zabel
parent 2737dcb3c4
commit 62d11b80ea
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/reset/core.c
View File

@@ -132,20 +132,21 @@ int reset_controller_register(struct reset_controller_dev *rcdev)
if ((rcdev->of_node && rcdev->fwnode) || (rcdev->of_xlate && rcdev->fwnode_xlate))
return -EINVAL;
if (!rcdev->of_node && !rcdev->fwnode) {
if (rcdev->of_node && !rcdev->fwnode)
rcdev->fwnode = of_fwnode_handle(rcdev->of_node);
if (!rcdev->fwnode) {
rcdev->fwnode = dev_fwnode(rcdev->dev);
if (!rcdev->fwnode)
return -EINVAL;
}
if (rcdev->of_node) {
rcdev->fwnode = of_fwnode_handle(rcdev->of_node);
if (rcdev->of_xlate)
rcdev->fwnode_reset_n_cells = rcdev->of_reset_n_cells;
}
if (rcdev->fwnode && !rcdev->fwnode_xlate) {
rcdev->fwnode_reset_n_cells = 1;
if (!rcdev->fwnode_xlate && !rcdev->of_xlate) {
rcdev->fwnode_xlate = fwnode_reset_simple_xlate;
rcdev->fwnode_reset_n_cells = 1;
}
INIT_LIST_HEAD(&rcdev->reset_control_head);