bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-21 08:13:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm/tests: Add tests for Broadcast RGB property

Browse Source 
This had a bunch of kunit tests to make sure our code to handle the
Broadcast RGB property behaves properly.

This requires bringing a bit of infrastructure to create mock HDMI
connectors, with custom EDIDs.

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240527-kms-hdmi-connector-state-v15-19-c5af16c3aae2@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
This commit is contained in:
Maxime Ripard
2024-05-27 15:58:08 +02:00
parent ab52af4ba7
commit 73af58c1b4
2 changed files with 267 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

116
drivers/gpu/drm/tests/drm_connector_test.c
View File

@@ -581,6 +581,63 @@ static struct kunit_suite drm_get_tv_mode_from_name_test_suite = {
.test_cases = drm_get_tv_mode_from_name_tests,
};
struct drm_hdmi_connector_get_broadcast_rgb_name_test {
unsigned int kind;
const char *expected_name;
};
#define BROADCAST_RGB_TEST(_kind, _name) \
{ \
.kind = _kind, \
.expected_name = _name, \
}
static void drm_test_drm_hdmi_connector_get_broadcast_rgb_name(struct kunit *test)
{
const struct drm_hdmi_connector_get_broadcast_rgb_name_test *params =
test->param_value;
KUNIT_EXPECT_STREQ(test,
drm_hdmi_connector_get_broadcast_rgb_name(params->kind),
params->expected_name);
}
static const
struct drm_hdmi_connector_get_broadcast_rgb_name_test
drm_hdmi_connector_get_broadcast_rgb_name_valid_tests[] = {
BROADCAST_RGB_TEST(DRM_HDMI_BROADCAST_RGB_AUTO, "Automatic"),
BROADCAST_RGB_TEST(DRM_HDMI_BROADCAST_RGB_FULL, "Full"),
BROADCAST_RGB_TEST(DRM_HDMI_BROADCAST_RGB_LIMITED, "Limited 16:235"),
};
static void
drm_hdmi_connector_get_broadcast_rgb_name_valid_desc(const struct drm_hdmi_connector_get_broadcast_rgb_name_test *t,
char *desc)
{
sprintf(desc, "%s", t->expected_name);
}
KUNIT_ARRAY_PARAM(drm_hdmi_connector_get_broadcast_rgb_name_valid,
drm_hdmi_connector_get_broadcast_rgb_name_valid_tests,
drm_hdmi_connector_get_broadcast_rgb_name_valid_desc);
static void drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid(struct kunit *test)
{
KUNIT_EXPECT_NULL(test, drm_hdmi_connector_get_broadcast_rgb_name(3));
};
static struct kunit_case drm_hdmi_connector_get_broadcast_rgb_name_tests[] = {
KUNIT_CASE_PARAM(drm_test_drm_hdmi_connector_get_broadcast_rgb_name,
drm_hdmi_connector_get_broadcast_rgb_name_valid_gen_params),
KUNIT_CASE(drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid),
{ }
};
static struct kunit_suite drm_hdmi_connector_get_broadcast_rgb_name_test_suite = {
.name = "drm_hdmi_connector_get_broadcast_rgb_name",
.test_cases = drm_hdmi_connector_get_broadcast_rgb_name_tests,
};
struct drm_hdmi_connector_get_output_format_name_test {
unsigned int kind;
const char *expected_name;
@@ -639,6 +696,63 @@ static struct kunit_suite drm_hdmi_connector_get_output_format_name_test_suite =
.test_cases = drm_hdmi_connector_get_output_format_name_tests,
};
static void drm_test_drm_connector_attach_broadcast_rgb_property(struct kunit *test)
{
struct drm_connector_init_priv *priv = test->priv;
struct drm_connector *connector = &priv->connector;
struct drm_property *prop;
int ret;
ret = drmm_connector_init(&priv->drm, connector,
&dummy_funcs,
DRM_MODE_CONNECTOR_HDMIA,
&priv->ddc);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = drm_connector_attach_broadcast_rgb_property(connector);
KUNIT_ASSERT_EQ(test, ret, 0);
prop = connector->broadcast_rgb_property;
KUNIT_ASSERT_NOT_NULL(test, prop);
KUNIT_EXPECT_NOT_NULL(test, drm_mode_obj_find_prop_id(&connector->base, prop->base.id));
}
static void drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector(struct kunit *test)
{
struct drm_connector_init_priv *priv = test->priv;
struct drm_connector *connector = &priv->connector;
struct drm_property *prop;
int ret;
ret = drmm_connector_hdmi_init(&priv->drm, connector,
&dummy_funcs,
&dummy_hdmi_funcs,
DRM_MODE_CONNECTOR_HDMIA,
&priv->ddc,
BIT(HDMI_COLORSPACE_RGB),
8);
KUNIT_EXPECT_EQ(test, ret, 0);
ret = drm_connector_attach_broadcast_rgb_property(connector);
KUNIT_ASSERT_EQ(test, ret, 0);
prop = connector->broadcast_rgb_property;
KUNIT_ASSERT_NOT_NULL(test, prop);
KUNIT_EXPECT_NOT_NULL(test, drm_mode_obj_find_prop_id(&connector->base, prop->base.id));
}
static struct kunit_case drm_connector_attach_broadcast_rgb_property_tests[] = {
KUNIT_CASE(drm_test_drm_connector_attach_broadcast_rgb_property),
KUNIT_CASE(drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector),
{ }
};
static struct kunit_suite drm_connector_attach_broadcast_rgb_property_test_suite = {
.name = "drm_connector_attach_broadcast_rgb_property",
.init = drm_test_connector_init,
.test_cases = drm_connector_attach_broadcast_rgb_property_tests,
};
/*
* Test that for a given mode, with 8bpc and an RGB output the TMDS
* character rate is equal to the mode pixel clock.
@@ -937,8 +1051,10 @@ static struct kunit_suite drm_hdmi_compute_mode_clock_test_suite = {
kunit_test_suites(
&drmm_connector_hdmi_init_test_suite,
&drmm_connector_init_test_suite,
&drm_connector_attach_broadcast_rgb_property_test_suite,
&drm_get_tv_mode_from_name_test_suite,
&drm_hdmi_compute_mode_clock_test_suite,
&drm_hdmi_connector_get_broadcast_rgb_name_test_suite,
&drm_hdmi_connector_get_output_format_name_test_suite
);