mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
net: use get_random_u{16,32,64}() where appropriate
Use the typed random integer helpers instead of get_random_bytes() when filling a single integer variable. The helpers return the value directly, require no pointer or size argument, and better express intent. Skipped sites writing into __be16 (netdevsim) and __le64 (ceph) fields where a direct assignment would trigger sparse endianness warnings. Signed-off-by: David Carlier <devnexen@gmail.com> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20260407150758.5889-1-devnexen@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
committed by
Jakub Kicinski
parent
581d28606c
commit
9addea5d44
@@ -72,7 +72,7 @@ static void subflow_req_create_thmac(struct mptcp_subflow_request_sock *subflow_
|
||||
struct mptcp_sock *msk = subflow_req->msk;
|
||||
u8 hmac[SHA256_DIGEST_SIZE];
|
||||
|
||||
get_random_bytes(&subflow_req->local_nonce, sizeof(u32));
|
||||
subflow_req->local_nonce = get_random_u32();
|
||||
|
||||
subflow_generate_hmac(READ_ONCE(msk->local_key),
|
||||
READ_ONCE(msk->remote_key),
|
||||
@@ -1639,7 +1639,7 @@ int __mptcp_subflow_connect(struct sock *sk, const struct mptcp_pm_local *local,
|
||||
ssk = sf->sk;
|
||||
subflow = mptcp_subflow_ctx(ssk);
|
||||
do {
|
||||
get_random_bytes(&subflow->local_nonce, sizeof(u32));
|
||||
subflow->local_nonce = get_random_u32();
|
||||
} while (!subflow->local_nonce);
|
||||
|
||||
/* if 'IPADDRANY', the ID will be set later, after the routing */
|
||||
|
||||
Reference in New Issue
Block a user