bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

net: use get_random_u{16,32,64}() where appropriate

Browse Source 
Use the typed random integer helpers instead of
get_random_bytes() when filling a single integer variable.
The helpers return the value directly, require no pointer
or size argument, and better express intent.

Skipped sites writing into __be16 (netdevsim) and __le64
(ceph) fields where a direct assignment would trigger
sparse endianness warnings.

Signed-off-by: David Carlier <devnexen@gmail.com>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260407150758.5889-1-devnexen@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
David Carlier
2026-04-07 16:07:58 +01:00
committed by Jakub Kicinski
parent 581d28606c
commit 9addea5d44
7 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/netdevsim/psample.c
View File

@@ -94,7 +94,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample,
if (psample->out_tc_occ_max) { if (psample->out_tc_occ_max) {
u64 out_tc_occ; u64 out_tc_occ;
get_random_bytes(&out_tc_occ, sizeof(u64)); out_tc_occ = get_random_u64();
md->out_tc_occ = out_tc_occ & (psample->out_tc_occ_max - 1); md->out_tc_occ = out_tc_occ & (psample->out_tc_occ_max - 1);
md->out_tc_occ_valid = 1; md->out_tc_occ_valid = 1;
} }
@@ -102,7 +102,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample,
if (psample->latency_max) { if (psample->latency_max) {
u64 latency; u64 latency;
get_random_bytes(&latency, sizeof(u64)); latency = get_random_u64();
md->latency = latency & (psample->latency_max - 1); md->latency = latency & (psample->latency_max - 1);
md->latency_valid = 1; md->latency_valid = 1;
} }

2
net/core/net_namespace.c
View File

@@ -411,7 +411,7 @@ static __net_init int preinit_net(struct net *net, struct user_namespace *user_n
ref_tracker_dir_init(&net->refcnt_tracker, 128, "net_refcnt"); ref_tracker_dir_init(&net->refcnt_tracker, 128, "net_refcnt");
ref_tracker_dir_init(&net->notrefcnt_tracker, 128, "net_notrefcnt"); ref_tracker_dir_init(&net->notrefcnt_tracker, 128, "net_notrefcnt");
get_random_bytes(&net->hash_mix, sizeof(u32)); net->hash_mix = get_random_u32();
net->dev_base_seq = 1; net->dev_base_seq = 1;
net->user_ns = user_ns; net->user_ns = user_ns;

2
net/mac80211/mesh_plink.c
View File

@@ -712,7 +712,7 @@ void mesh_plink_timer(struct timer_list *t)
"Mesh plink for %pM (retry, timeout): %d %d\n", "Mesh plink for %pM (retry, timeout): %d %d\n",
sta->sta.addr, sta->mesh->plink_retries, sta->sta.addr, sta->mesh->plink_retries,
sta->mesh->plink_timeout); sta->mesh->plink_timeout);
get_random_bytes(&rand, sizeof(u32)); rand = get_random_u32();
sta->mesh->plink_timeout = sta->mesh->plink_timeout + sta->mesh->plink_timeout = sta->mesh->plink_timeout +
rand % sta->mesh->plink_timeout; rand % sta->mesh->plink_timeout;
++sta->mesh->plink_retries; ++sta->mesh->plink_retries;

4
net/mptcp/subflow.c
View File

@@ -72,7 +72,7 @@ static void subflow_req_create_thmac(struct mptcp_subflow_request_sock *subflow_
struct mptcp_sock *msk = subflow_req->msk; struct mptcp_sock *msk = subflow_req->msk;
u8 hmac[SHA256_DIGEST_SIZE]; u8 hmac[SHA256_DIGEST_SIZE];
get_random_bytes(&subflow_req->local_nonce, sizeof(u32)); subflow_req->local_nonce = get_random_u32();
subflow_generate_hmac(READ_ONCE(msk->local_key), subflow_generate_hmac(READ_ONCE(msk->local_key),
READ_ONCE(msk->remote_key), READ_ONCE(msk->remote_key),
@@ -1639,7 +1639,7 @@ int __mptcp_subflow_connect(struct sock *sk, const struct mptcp_pm_local *local,
ssk = sf->sk; ssk = sf->sk;
subflow = mptcp_subflow_ctx(ssk); subflow = mptcp_subflow_ctx(ssk);
do { do {
get_random_bytes(&subflow->local_nonce, sizeof(u32)); subflow->local_nonce = get_random_u32();
} while (!subflow->local_nonce); } while (!subflow->local_nonce);
/* if 'IPADDRANY', the ID will be set later, after the routing */ /* if 'IPADDRANY', the ID will be set later, after the routing */

2
net/openvswitch/flow_table.c
View File

@@ -167,7 +167,7 @@ static struct table_instance *table_instance_alloc(int new_size)
ti->n_buckets = new_size; ti->n_buckets = new_size;
ti->node_ver = 0; ti->node_ver = 0;
get_random_bytes(&ti->hash_seed, sizeof(u32)); ti->hash_seed = get_random_u32();
return ti; return ti;
} }

4
net/sctp/sm_make_chunk.c
View File

@@ -2727,7 +2727,7 @@ __u32 sctp_generate_tag(const struct sctp_endpoint *ep)
__u32 x; __u32 x;
do { do {
get_random_bytes(&x, sizeof(__u32)); x = get_random_u32();
} while (x == 0); } while (x == 0);
return x; return x;
@@ -2738,7 +2738,7 @@ __u32 sctp_generate_tsn(const struct sctp_endpoint *ep)
{ {
__u32 retval; __u32 retval;
get_random_bytes(&retval, sizeof(__u32)); retval = get_random_u32();
return retval; return retval;
} }

2
net/tipc/node.c
View File

@@ -1275,7 +1275,7 @@ void tipc_node_check_dest(struct net *net, u32 addr,
goto exit; goto exit;
if_name = strchr(b->name, ':') + 1; if_name = strchr(b->name, ':') + 1;
get_random_bytes(&session, sizeof(u16)); session = get_random_u16();
if (!tipc_link_create(net, if_name, b->identity, b->tolerance, if (!tipc_link_create(net, if_name, b->identity, b->tolerance,
b->net_plane, b->mtu, b->priority, b->net_plane, b->mtu, b->priority,
b->min_win, b->max_win, session, b->min_win, b->max_win, session,