bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

block: use sysfs_emit in sysfs show functions

Browse Source 
Replace sprintf() with sysfs_emit() in sysfs show functions.
sysfs_emit() is preferred for formatting sysfs output because it
provides safer bounds checking.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://patch.msgid.link/20260402164958.894879-4-thorsten.blum@linux.dev
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Thorsten Blum
2026-04-02 18:50:00 +02:00
committed by Jens Axboe
parent 4e56428ed4
commit a175ee8273
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
block/partitions/core.c
View File

@@ -8,6 +8,7 @@
#include <linux/major.h> #include <linux/major.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/string.h> #include <linux/string.h>
#include <linux/sysfs.h>
#include <linux/ctype.h> #include <linux/ctype.h>
#include <linux/vmalloc.h> #include <linux/vmalloc.h>
#include <linux/raid/detect.h> #include <linux/raid/detect.h>
@@ -177,31 +178,31 @@ static struct parsed_partitions *check_partition(struct gendisk *hd)
static ssize_t part_partition_show(struct device *dev, static ssize_t part_partition_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%d\n", bdev_partno(dev_to_bdev(dev))); return sysfs_emit(buf, "%d\n", bdev_partno(dev_to_bdev(dev)));
} }
static ssize_t part_start_show(struct device *dev, static ssize_t part_start_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect); return sysfs_emit(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect);
} }
static ssize_t part_ro_show(struct device *dev, static ssize_t part_ro_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%d\n", bdev_read_only(dev_to_bdev(dev))); return sysfs_emit(buf, "%d\n", bdev_read_only(dev_to_bdev(dev)));
} }
static ssize_t part_alignment_offset_show(struct device *dev, static ssize_t part_alignment_offset_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev))); return sysfs_emit(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));
} }
static ssize_t part_discard_alignment_show(struct device *dev, static ssize_t part_discard_alignment_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev))); return sysfs_emit(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));
} }
static DEVICE_ATTR(partition, 0444, part_partition_show, NULL); static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);