mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
Merge tag 'vfs-7.1-rc1.kino' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
Pull vfs i_ino updates from Christian Brauner: "For historical reasons, the inode->i_ino field is an unsigned long, which means that it's 32 bits on 32 bit architectures. This has caused a number of filesystems to implement hacks to hash a 64-bit identifier into a 32-bit field, and deprives us of a universal identifier field for an inode. This changes the inode->i_ino field from an unsigned long to a u64. This shouldn't make any material difference on 64-bit hosts, but 32-bit hosts will see struct inode grow by at least 4 bytes. This could have effects on slabcache sizes and field alignment. The bulk of the changes are to format strings and tracepoints, since the kernel itself doesn't care that much about the i_ino field. The first patch changes some vfs function arguments, so check that one out carefully. With this change, we may be able to shrink some inode structures. For instance, struct nfs_inode has a fileid field that holds the 64-bit inode number. With this set of changes, that field could be eliminated. I'd rather leave that sort of cleanups for later just to keep this simple" * tag 'vfs-7.1-rc1.kino' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs: nilfs2: fix 64-bit division operations in nilfs_bmap_find_target_in_group() EVM: add comment describing why ino field is still unsigned long vfs: remove externs from fs.h on functions modified by i_ino widening treewide: fix missed i_ino format specifier conversions ext4: fix signed format specifier in ext4_load_inode trace event treewide: change inode->i_ino from unsigned long to u64 nilfs2: widen trace event i_ino fields to u64 f2fs: widen trace event i_ino fields to u64 ext4: widen trace event i_ino fields to u64 zonefs: widen trace event i_ino fields to u64 hugetlbfs: widen trace event i_ino fields to u64 ext2: widen trace event i_ino fields to u64 cachefiles: widen trace event i_ino fields to u64 vfs: widen trace event i_ino fields to u64 net: change sock.sk_ino and sock_i_ino() to u64 audit: widen ino fields to u64 vfs: widen inode hash/lookup functions to u64
This commit is contained in:
@@ -848,12 +848,12 @@ void __ext4_error_inode(struct inode *inode, const char *function,
|
||||
vaf.va = &args;
|
||||
if (block)
|
||||
printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: "
|
||||
"inode #%lu: block %llu: comm %s: %pV\n",
|
||||
"inode #%llu: block %llu: comm %s: %pV\n",
|
||||
inode->i_sb->s_id, function, line, inode->i_ino,
|
||||
block, current->comm, &vaf);
|
||||
else
|
||||
printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: "
|
||||
"inode #%lu: comm %s: %pV\n",
|
||||
"inode #%llu: comm %s: %pV\n",
|
||||
inode->i_sb->s_id, function, line, inode->i_ino,
|
||||
current->comm, &vaf);
|
||||
va_end(args);
|
||||
@@ -888,13 +888,13 @@ void __ext4_error_file(struct file *file, const char *function,
|
||||
vaf.va = &args;
|
||||
if (block)
|
||||
printk(KERN_CRIT
|
||||
"EXT4-fs error (device %s): %s:%d: inode #%lu: "
|
||||
"EXT4-fs error (device %s): %s:%d: inode #%llu: "
|
||||
"block %llu: comm %s: path %s: %pV\n",
|
||||
inode->i_sb->s_id, function, line, inode->i_ino,
|
||||
block, current->comm, path, &vaf);
|
||||
else
|
||||
printk(KERN_CRIT
|
||||
"EXT4-fs error (device %s): %s:%d: inode #%lu: "
|
||||
"EXT4-fs error (device %s): %s:%d: inode #%llu: "
|
||||
"comm %s: path %s: %pV\n",
|
||||
inode->i_sb->s_id, function, line, inode->i_ino,
|
||||
current->comm, path, &vaf);
|
||||
@@ -1035,14 +1035,14 @@ void __ext4_warning_inode(const struct inode *inode, const char *function,
|
||||
vaf.fmt = fmt;
|
||||
vaf.va = &args;
|
||||
printk(KERN_WARNING "EXT4-fs warning (device %s): %s:%d: "
|
||||
"inode #%lu: comm %s: %pV\n", inode->i_sb->s_id,
|
||||
"inode #%llu: comm %s: %pV\n", inode->i_sb->s_id,
|
||||
function, line, inode->i_ino, current->comm, &vaf);
|
||||
va_end(args);
|
||||
}
|
||||
|
||||
void __ext4_grp_locked_error(const char *function, unsigned int line,
|
||||
struct super_block *sb, ext4_group_t grp,
|
||||
unsigned long ino, ext4_fsblk_t block,
|
||||
u64 ino, ext4_fsblk_t block,
|
||||
const char *fmt, ...)
|
||||
__releases(bitlock)
|
||||
__acquires(bitlock)
|
||||
@@ -1061,7 +1061,7 @@ __acquires(bitlock)
|
||||
printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ",
|
||||
sb->s_id, function, line, grp);
|
||||
if (ino)
|
||||
printk(KERN_CONT "inode %lu: ", ino);
|
||||
printk(KERN_CONT "inode %llu: ", ino);
|
||||
if (block)
|
||||
printk(KERN_CONT "block %llu:",
|
||||
(unsigned long long) block);
|
||||
@@ -1170,7 +1170,7 @@ static void dump_orphan_list(struct super_block *sb, struct ext4_sb_info *sbi)
|
||||
list_for_each(l, &sbi->s_orphan) {
|
||||
struct inode *inode = orphan_list_entry(l);
|
||||
printk(KERN_ERR " "
|
||||
"inode %s:%lu at %p: mode %o, nlink %d, next %d\n",
|
||||
"inode %s:%llu at %p: mode %o, nlink %d, next %d\n",
|
||||
inode->i_sb->s_id, inode->i_ino, inode,
|
||||
inode->i_mode, inode->i_nlink,
|
||||
NEXT_ORPHAN(inode));
|
||||
@@ -1442,7 +1442,7 @@ static void ext4_free_in_core_inode(struct inode *inode)
|
||||
{
|
||||
fscrypt_free_inode(inode);
|
||||
if (!list_empty(&(EXT4_I(inode)->i_fc_list))) {
|
||||
pr_warn("%s: inode %ld still in fc list",
|
||||
pr_warn("%s: inode %llu still in fc list",
|
||||
__func__, inode->i_ino);
|
||||
}
|
||||
kmem_cache_free(ext4_inode_cachep, EXT4_I(inode));
|
||||
@@ -1452,7 +1452,7 @@ static void ext4_destroy_inode(struct inode *inode)
|
||||
{
|
||||
if (ext4_inode_orphan_tracked(inode)) {
|
||||
ext4_msg(inode->i_sb, KERN_ERR,
|
||||
"Inode %lu (%p): inode tracked as orphan!",
|
||||
"Inode %llu (%p): inode tracked as orphan!",
|
||||
inode->i_ino, EXT4_I(inode));
|
||||
print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS, 16, 4,
|
||||
EXT4_I(inode), sizeof(struct ext4_inode_info),
|
||||
@@ -1463,7 +1463,7 @@ static void ext4_destroy_inode(struct inode *inode)
|
||||
if (!(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_ERROR_FS) &&
|
||||
WARN_ON_ONCE(EXT4_I(inode)->i_reserved_data_blocks))
|
||||
ext4_msg(inode->i_sb, KERN_ERR,
|
||||
"Inode %lu (%p): i_reserved_data_blocks (%u) not cleared!",
|
||||
"Inode %llu (%p): i_reserved_data_blocks (%u) not cleared!",
|
||||
inode->i_ino, EXT4_I(inode),
|
||||
EXT4_I(inode)->i_reserved_data_blocks);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user