bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 14:53:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm/tests: shmem: Hold reservation lock around vmap/vunmap

Browse Source 
Acquire and release the GEM object's reservation lock around vmap and
vunmap operations. The tests use vmap_locked, which led to errors such
as show below.

[  122.292030] WARNING: CPU: 3 PID: 1413 at drivers/gpu/drm/drm_gem_shmem_helper.c:390 drm_gem_shmem_vmap_locked+0x3a3/0x6f0

[  122.468066] WARNING: CPU: 3 PID: 1413 at drivers/gpu/drm/drm_gem_shmem_helper.c:293 drm_gem_shmem_pin_locked+0x1fe/0x350

[  122.563504] WARNING: CPU: 3 PID: 1413 at drivers/gpu/drm/drm_gem_shmem_helper.c:234 drm_gem_shmem_get_pages_locked+0x23c/0x370

[  122.662248] WARNING: CPU: 2 PID: 1413 at drivers/gpu/drm/drm_gem_shmem_helper.c:452 drm_gem_shmem_vunmap_locked+0x101/0x330

Only export the new vmap/vunmap helpers for Kunit tests. These are
not interfaces for regular drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 954907f714 ("drm/shmem-helper: Refactor locked/unlocked functions")
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.16+
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patch.msgid.link/20251212160317.287409-4-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann
2025-12-12 17:00:34 +01:00
parent b47b9ecef3
commit cda83b099f
3 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/gpu/drm/drm_gem_shmem_helper.c
View File

@@ -15,6 +15,8 @@
#include <asm/set_memory.h>
#endif
#include <kunit/visibility.h>
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_drv.h>
@@ -901,6 +903,37 @@ fail_detach:
}
EXPORT_SYMBOL_GPL(drm_gem_shmem_prime_import_no_map);
/*
* Kunit helpers
*/
#if IS_ENABLED(CONFIG_KUNIT)
int drm_gem_shmem_vmap(struct drm_gem_shmem_object *shmem, struct iosys_map *map)
{
struct drm_gem_object *obj = &shmem->base;
int ret;
ret = dma_resv_lock_interruptible(obj->resv, NULL);
if (ret)
return ret;
ret = drm_gem_shmem_vmap_locked(shmem, map);
dma_resv_unlock(obj->resv);
return ret;
}
EXPORT_SYMBOL_IF_KUNIT(drm_gem_shmem_vmap);
void drm_gem_shmem_vunmap(struct drm_gem_shmem_object *shmem, struct iosys_map *map)
{
struct drm_gem_object *obj = &shmem->base;
dma_resv_lock_interruptible(obj->resv, NULL);
drm_gem_shmem_vunmap_locked(shmem, map);
dma_resv_unlock(obj->resv);
}
EXPORT_SYMBOL_IF_KUNIT(drm_gem_shmem_vunmap);
#endif
MODULE_DESCRIPTION("DRM SHMEM memory-management helpers");
MODULE_IMPORT_NS("DMA_BUF");
MODULE_LICENSE("GPL v2");