bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

nvme: expose active quirks in sysfs

Browse Source 
Currently, there is no straightforward way for a user to inspect
which quirks are active for a given device from userspace.

Add a new "quirks" sysfs attribute to the nvme controller device.

Reading this file will display a human-readable list
of all active quirks, with each quirk name on a new line.
If no quirks are active, it will display "none".

Tested-by: John Meneghini <jmeneghi@redhat.com>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
This commit is contained in:
Maurizio Lombardi
2025-11-03 15:44:06 +01:00
committed by Keith Busch
parent f947d9e77b
commit ddfb8b322b
2 changed files with 77 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/nvme/host/sysfs.c
View File

@@ -601,6 +601,28 @@ static ssize_t dctype_show(struct device *dev,
}
static DEVICE_ATTR_RO(dctype);
static ssize_t quirks_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
int count = 0, i;
struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
unsigned long quirks = ctrl->quirks;
if (!quirks)
return sysfs_emit(buf, "none\n");
for (i = 0; quirks; ++i) {
if (quirks & 1) {
count += sysfs_emit_at(buf, count, "%s\n",
nvme_quirk_name(BIT(i)));
}
quirks >>= 1;
}
return count;
}
static DEVICE_ATTR_RO(quirks);
#ifdef CONFIG_NVME_HOST_AUTH
static ssize_t nvme_ctrl_dhchap_secret_show(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -742,6 +764,7 @@ static struct attribute *nvme_dev_attrs[] = {
&dev_attr_kato.attr,
&dev_attr_cntrltype.attr,
&dev_attr_dctype.attr,
&dev_attr_quirks.attr,
#ifdef CONFIG_NVME_HOST_AUTH
&dev_attr_dhchap_secret.attr,
&dev_attr_dhchap_ctrl_secret.attr,