mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
md: document lifetime of internal rdev pointer.
The rdev pointer kept in the local 'config' for each for raid1, raid10, raid4/5/6 has non-obvious lifetime rules. Sometimes RCU is needed, sometimes a lock, something nothing. Add documentation to explain this. Signed-off-by: NeilBrown <neilb@suse.com> Signed-off-by: Shaohua Li <sh.li@alibaba-inc.com>
This commit is contained in:
@@ -450,6 +450,18 @@ enum {
|
||||
* HANDLE gets cleared if stripe_handle leaves nothing locked.
|
||||
*/
|
||||
|
||||
/* Note: disk_info.rdev can be set to NULL asynchronously by raid5_remove_disk.
|
||||
* There are three safe ways to access disk_info.rdev.
|
||||
* 1/ when holding mddev->reconfig_mutex
|
||||
* 2/ when resync/recovery/reshape is known to be happening - i.e. in code that
|
||||
* is called as part of performing resync/recovery/reshape.
|
||||
* 3/ while holding rcu_read_lock(), use rcu_dereference to get the pointer
|
||||
* and if it is non-NULL, increment rdev->nr_pending before dropping the RCU
|
||||
* lock.
|
||||
* When .rdev is set to NULL, the nr_pending count checked again and if
|
||||
* it has been incremented, the pointer is put back in .rdev.
|
||||
*/
|
||||
|
||||
struct disk_info {
|
||||
struct md_rdev *rdev, *replacement;
|
||||
struct page *extra_page; /* extra page to use in prexor */
|
||||
|
||||
Reference in New Issue
Block a user