bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

mm: update outdated comments for removed scan_swap_map_slots()

Browse Source 
The function scan_swap_map_slots() was removed in commit 0ff67f990b
("mm, swap: remove swap slot cache").

The three comments referencing it simply noted that ->flags can be updated
non-atomically by scan_swap_map_slots() to justify a data_race()
annotation.  Since the function no longer exists, drop the parenthetical
reference while keeping the data_race() justification intact: ->flags can
still be updated non-atomically by other paths (e.g., swapoff clearing
SWP_WRITEOK).

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Link: https://lkml.kernel.org/r/20260321105814.7053-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Barry Song <baohua@kernel.org>
Cc: Chris Li <chrisl@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Julia Lawall <julia.lawall@inria.fr>
Cc: Kairui Song <kasong@tencent.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Wei Xu <weixugc@google.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Kexin Sun
2026-03-21 18:58:14 +08:00
committed by Andrew Morton
parent 3cb0dc0d0e
commit f2a48f8fb5
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mm/page_io.c
View File

@@ -450,14 +450,14 @@ void __swap_writepage(struct folio *folio, struct swap_iocb **swap_plug)
VM_BUG_ON_FOLIO(!folio_test_swapcache(folio), folio); VM_BUG_ON_FOLIO(!folio_test_swapcache(folio), folio);
/* /*
* ->flags can be updated non-atomically (scan_swap_map_slots), * ->flags can be updated non-atomically,
* but that will never affect SWP_FS_OPS, so the data_race * but that will never affect SWP_FS_OPS, so the data_race
* is safe. * is safe.
*/ */
if (data_race(sis->flags & SWP_FS_OPS)) if (data_race(sis->flags & SWP_FS_OPS))
swap_writepage_fs(folio, swap_plug); swap_writepage_fs(folio, swap_plug);
/* /*
* ->flags can be updated non-atomically (scan_swap_map_slots), * ->flags can be updated non-atomically,
* but that will never affect SWP_SYNCHRONOUS_IO, so the data_race * but that will never affect SWP_SYNCHRONOUS_IO, so the data_race
* is safe. * is safe.
*/ */

2
mm/vmscan.c
View File

@@ -1065,7 +1065,7 @@ static bool may_enter_fs(struct folio *folio, gfp_t gfp_mask)
/* /*
* We can "enter_fs" for swap-cache with only __GFP_IO * We can "enter_fs" for swap-cache with only __GFP_IO
* providing this isn't SWP_FS_OPS. * providing this isn't SWP_FS_OPS.
* ->flags can be updated non-atomically (scan_swap_map_slots), * ->flags can be updated non-atomically,
* but that will never affect SWP_FS_OPS, so the data_race * but that will never affect SWP_FS_OPS, so the data_race
* is safe. * is safe.
*/ */