Thomas Zimmermann
2a7e5f4531
drm/ast: Implement atomic enable/disable for encoders
...
The CRTC helpers contain code to enable and disable DisplayPort
connectors. Implement this functionality in the respective connector's
atomic_enable/atomic_disable callbacks. DRM's atomic-modesetting
helpers will call the functions as part of the atomic commit.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240627153638.8765-2-tzimmermann@suse.de
2024-07-03 09:38:07 +02:00
Jani Nikula
2210093478
drm/exynos/vidi: convert to struct drm_edid
...
Prefer the struct drm_edid based functions for storing the EDID and
updating the connector.
It would be better if the vidi connection ioctl passed in the EDID size
separately instead of relying on the extension count specified in the
EDID, but that's what we have to rely on.
Signed-off-by: Jani Nikula <jani.nikula@intel.com >
Signed-off-by: Inki Dae <inki.dae@samsung.com >
2024-07-03 13:00:16 +09:00
Jani Nikula
10b566f21b
drm/exynos/vidi: simplify fake edid handling
...
Avoid assigning fake_edid_info to ctx->raw_edid. Always keep
ctx->raw_edid either an allocated pointer or NULL. Defer fake_edid_info
handling to .get_modes().
This should be functionally equivalent but slightly easier to follow.
Signed-off-by: Jani Nikula <jani.nikula@intel.com >
Signed-off-by: Inki Dae <inki.dae@samsung.com >
2024-07-03 13:00:14 +09:00
Jani Nikula
679ca52384
drm/exynos/vidi: use drm_edid_duplicate()
...
Don't open code drm_edid_duplicate(). While at it, drop the error
message on allocation failure.
Signed-off-by: Jani Nikula <jani.nikula@intel.com >
Signed-off-by: Inki Dae <inki.dae@samsung.com >
2024-07-03 13:00:12 +09:00
Inki Dae
98e05e40e9
Merge tag 'exynos-drm-fixes-for-v6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into exynos-drm-next
...
Regression fix
- Fix an regression issue by adding 640x480 fallback mode
for Exynos HDMI driver.
Bug fix
- Fix a memory leak by ensuring the duplicated EDID is properly freed in the get_modes function.
Code cleanup
- Remove redundant driver owner initialization since platform_driver_register() sets it automatically.
2024-07-03 13:00:01 +09:00
Alex Deucher
d041726443
drm/amdgpu/atomfirmware: silence UBSAN warning
...
This is a variable sized array.
Link: https://lists.freedesktop.org/archives/amd-gfx/2024-June/110420.html
Tested-by: Jeff Layton <jlayton@kernel.org >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org
2024-07-02 18:34:05 -04:00
Alex Deucher
4ed6a3689c
drm/amdgpu/atomfirmware: silence UBSAN warning
...
This is a variable sized array.
Link: https://lists.freedesktop.org/archives/amd-gfx/2024-June/110420.html
Tested-by: Jeff Layton <jlayton@kernel.org >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:07:31 -04:00
Sunil Khatri
ea67deb03c
drm/amdgpu: fix out of bounds access in gfx11 during ip dump
...
During ip dump in gfx11 the index variable is reused but is
not reinitialized to 0 and this causes the index calculation
to be wrong and access out of bound access.
Acked-by: Christian König <christian.koenig@amd.com >
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:07:16 -04:00
Tim Huang
94845ea057
drm/amdgpu: add firmware for PSP IP v14.0.4
...
This patch is to add firmware for PSP 14.0.4.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:07:10 -04:00
Tim Huang
b709f949f0
drm/amdgpu: enable mode2 reset for SMU IP v14.0.4
...
Set the default reset method to mode2 for SMU 14.0.4.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:07:02 -04:00
Tim Huang
38a16bfe6f
drm/amdgpu: add SMU IP v14.0.4 discovery support
...
This patch is to add SMU 14.0.4 support
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:57 -04:00
Tim Huang
80ffdc273a
drm/amd/pm: add SMU IP v14.0.4 support
...
This patch is to add SMU 14.0.4 support.
Signed-off-by: Li Ma <li.ma@amd.com >
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:51 -04:00
Li Ma
11382d02fb
drm/amd/pm: smu v14.0.4 reuse smu v14.0.0 dpmtable
...
Replace IP VERSION with smu->is_apu in if condition.
And the dpmtable of smu v14.0.4 is same as smu v14.0.0.
Signed-off-by: Li Ma <li.ma@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:45 -04:00
Tim Huang
9cd2ad14d8
drm/amdgpu: add PSP IP v14.0.4 discovery support
...
This patch is to add PSP 14.0.4 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:36 -04:00
Tim Huang
c7c3f786b9
drm/amdgpu: add PSP IP v14.0.4 support
...
This patch is to add PSP 14.0.4 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:30 -04:00
Tim Huang
614a9f5ed5
drm/amdgpu: add firmware for VPE IP v6.1.3
...
This patch is to add firmware for VPE 6.1.3.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:24 -04:00
Tim Huang
ca15cd559f
drm/amdgpu: add VPE IP v6.1.3 discovery support
...
This patch is to add VPE 6.1.3 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:19 -04:00
Tim Huang
f3e2a425c6
drm/amdgpu: add VPE IP v6.1.3 support
...
This patch is to add VPE 6.1.3 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:13 -04:00
Tim Huang
410bb279a8
drm/amdgpu: Add NBIO IP v7.11.3 support
...
Enable setting soc21 common clockgating for NBIO 7.11.3.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:06 -04:00
Tim Huang
5aea871694
drm/amdgpu: add NBIO IP v7.11.3 discovery support
...
This patch is to add NBIO 7.11.3 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:06:00 -04:00
Tim Huang
6857669a22
drm/amdgpu: add firmware for SDMA IP v6.1.2
...
This patch is to add firmware for SDMA 6.1.2.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:53 -04:00
Tim Huang
71d8af38d3
drm/amdkfd: add KFD support for SDMA IP v6.1.2
...
Enable KFD setting SDMA info for SDMA 6.1.2.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:47 -04:00
Tim Huang
dfeccf4d54
drm/amdgpu: add SDMA IP v6.1.2 discovery support
...
This patch is to add SDMA 6.1.2 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:41 -04:00
Tim Huang
4448b1ff4d
drm/amdgpu: add firmware for GC IP v11.5.2
...
This patch is to add firmware for GC 11.5.2.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:35 -04:00
Tim Huang
53c3a37436
drm/amdkfd: add KFD support for GC IP v11.5.2
...
Enable KFD for GC 11.5.2.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:29 -04:00
Tim Huang
23c1ea0241
drm/amdgpu: add GC IP v11.5.2 to GC 11.5.0 family
...
This patch is to add GC 11.5.2 to GC 11.5.0 family.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Veerabadhran Gopalakrishnan <Veerabadhran.Gopalakrishnan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:23 -04:00
Tim Huang
43e4cc2299
drm/amdgpu: add GC IP v11.5.2 soc21 support
...
Add CG and PG flags for GFX IP v11.5.2 and
PG flags for VCN IP v4.0.5.
Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com >
Signed-off-by: Li Ma <li.ma@amd.com >
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Veerabadhran Gopalakrishnan <Veerabadhran.Gopalakrishnan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:15 -04:00
Tim Huang
98392782df
drm/amdgpu: add tmz support for GC IP v11.5.2
...
Add tmz support for GC 11.5.2.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:09 -04:00
Tim Huang
02cf3ed627
drm/amdgpu: add GFXHUB IP v11.5.2 support
...
This patch is to add GFXHUB 11.5.2 support.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:05:03 -04:00
Tim Huang
b6a343df46
drm/amdgpu: initialize GC IP v11.5.2
...
Initialize GC 11.5.2 and set gfx hw configuration.
Signed-off-by: Tim Huang <Tim.Huang@amd.com >
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:57 -04:00
Sunil Khatri
425c4a6f8b
drm/amdgpu: fix out of bounds access in gfx10 during ip dump
...
During ip dump in gfx10 the index variable is reused but is
not reinitialized to 0 and this causes the index calculation
to be wrong and access out of bound access.
Acked-by: Christian König <christian.koenig@amd.com >
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:49 -04:00
Jiapeng Chong
e931ab3eea
drm/amd/display: Fix warning comparing pointer to 0
...
Avoid pointer type value compared with 0 to make code clear.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c:14:12-13: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:47 -04:00
Jiapeng Chong
f4b1dbf413
drm/amd/display: Fix warning comparing pointer to 0
...
Avoid pointer type value compared with 0 to make code clear.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_dpmm/dml2_dpmm_factory.c:24:12-13: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:45 -04:00
Jiapeng Chong
dcac51bd10
drm/amd/display: Fix warning comparing pointer to 0
...
Avoid pointer type value compared with 0 to make code clear.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c:19:12-13: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:42 -04:00
Jiapeng Chong
5380092f65
drm/amd/display: Fix warning comparing pointer to 0
...
Avoid pointer type value compared with 0 to make code clear.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_factory.c:31:12-13: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:36 -04:00
Jiapeng Chong
fcb2f988ef
drm/amd/display: Fix unsigned comparison with less than zero
...
The return value from the call to dml21_find_dc_pipes_for_plane() is int.
However, the return value is being assigned to an unsigned int variable
'num_pipes', the condition if(num_pipes <= 0) is not rigorous enough,
so making 'num_pipes' an int.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:318:6-15: WARNING: Unsigned expression compared with zero: num_pipes <= 0.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:360:6-15: WARNING: Unsigned expression compared with zero: num_pipes <= 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9454
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-02 18:04:27 -04:00
Michal Wajdeczko
7c0389c615
drm/xe/guc: Demote GuC IDs usage message to debug
...
Printing message at INFO level about available GuC IDs is not that
important, DEBUG level is enough. It will also match message about
available doorbells:
[ ] xe ... [drm:xe_guc_id_mgr_init [xe]] GT0: using 65535 GuC IDs
[ ] xe ... [drm:xe_guc_db_mgr_init [xe]] GT0: using 256 doorbells
While at it, use proper "GuC" name.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com >
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240701193030.978-1-michal.wajdeczko@intel.com
2024-07-02 18:33:19 +02:00
Vinay Belgaumkar
aaa08078e7
drm/xe/bmg: Apply Wa_22019338487
...
Extend this WA to BMG GT as well. In this case media GT is
not affected. The cap frequencies and max allowed ggtt writes
are different as well. On BMG, we need to do a flush after 1100
GGTT writes, and we need to limit the GT frequency request
to 2133 Mhz during driver load and leave it at that value after
driver unloads.
v3: Fix checkpatch issue
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240701231529.2582452-2-vinay.belgaumkar@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
2024-07-02 12:14:00 -04:00
Vinay Belgaumkar
b0b2b50cdb
drm/xe/guc: Prevent use of uninitialized mutex
...
When skip_guc_pc is set and/or this is for a VF.
Fixes: 3b1592fb78 ("drm/xe/lnl: Apply Wa_22019338487")
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com >
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240701231529.2582452-1-vinay.belgaumkar@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
2024-07-02 12:14:00 -04:00
Rob Clark
7775352a5f
drm/msm/gem: Add missing rcu_dereference()
...
Fixes a sparse "different address spaces" error.
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202406280050.syeEwLTE-lkp@intel.com/
Signed-off-by: Rob Clark <robdclark@chromium.org >
Patchwork: https://patchwork.freedesktop.org/patch/601612/
2024-07-02 07:20:34 -07:00
Rob Clark
ad7f52996b
drm/msm/a6xx: Add missing __always_unused
...
The __build_asserts() function only exists to have a place to put
build-time asserts.
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202407010401.rfunrBSx-lkp@intel.com/
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Patchwork: https://patchwork.freedesktop.org/patch/601606/
2024-07-02 07:05:08 -07:00
Daniil Titov
fa17fbb0e4
drm/msm/adreno: Add support for Adreno 505 GPU
...
This GPU is found on SoCs such as MSM8937 (450 MHz), MSM8940 (475 MHz),
SDM439 (650 MHz).
Signed-off-by: Daniil Titov <daniilt971@gmail.com >
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org >
Signed-off-by: Barnabás Czémán <trabarni@gmail.com >
Patchwork: https://patchwork.freedesktop.org/patch/601411/
Signed-off-by: Rob Clark <robdclark@chromium.org >
2024-07-01 14:02:09 -07:00
Abhinav Kumar
71c5c23be8
drm/msm/dpu: check ubwc support before adding compressed formats
...
On QCM2290 chipset DPU does not support UBWC.
Add a dpu cap to indicate this and do not expose compressed formats
in this case.
changes since RFC:
- use ubwc enc and dec version of mdss_data instead of catalog
to decide if ubwc is supported
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com >
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Patchwork: https://patchwork.freedesktop.org/patch/601392/
Signed-off-by: Rob Clark <robdclark@chromium.org >
2024-07-01 13:54:40 -07:00
Pierre-Eric Pelloux-Prayer
6fb15dcbcf
drm/radeon: check bo_va->bo is non-NULL before using it
...
The call to radeon_vm_clear_freed might clear bo_va->bo, so
we have to check it before dereferencing it.
Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:54:22 -04:00
Roman Li
0ad4b4a2f6
drm/amd/display: Fix array-index-out-of-bounds in dml2/FCLKChangeSupport
...
[Why]
Potential out of bounds access in dml2_calculate_rq_and_dlg_params()
because the value of out_lowest_state_idx used as an index for FCLKChangeSupport
array can be greater than 1.
[How]
Currently dml2 core specifies identical values for all FCLKChangeSupport
elements. Always use index 0 in the condition to avoid out of bounds access.
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com >
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com >
Signed-off-by: Roman Li <Roman.Li@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:53:24 -04:00
Fangzhi Zuo
7ae37db29a
drm/amd/display: Update efficiency bandwidth for dcn351
...
Fix 4k240 underflow on dcn351
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com >
Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:52:24 -04:00
Tom Chung
9ef1548aea
drm/amd/display: Fix refresh rate range for some panel
...
[Why]
Some of the panels does not have the refresh rate range info
in base EDID and only have the refresh rate range info in
DisplayID block.
It will cause the max/min freesync refresh rate set to 0.
[How]
Try to parse the refresh rate range info from DisplayID if the
max/min refresh rate is 0.
Reviewed-by: Sun peng Li <sunpeng.li@amd.com >
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com >
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:51:15 -04:00
Alvin Lee
074b3a8867
drm/amd/display: Account for cursor prefetch BW in DML1 mode support
...
[Description]
We need to ensure to take into account cursor prefetch BW in
mode support or we may pass ModeQuery but fail an actual flip
which will cause a hang. Flip may fail because the cursor_pre_bw
is populated during mode programming (and mode programming is
never called prior to ModeQuery).
Reviewed-by: Chaitanya Dhere <chaitanya.dhere@amd.com >
Reviewed-by: Nevenko Stupar <nevenko.stupar@amd.com >
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com >
Signed-off-by: Alvin Lee <alvin.lee2@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:50:02 -04:00
Tom Chung
74ad26b36d
drm/amd/display: Add refresh rate range check
...
[Why]
We only enable the VRR while monitor usable refresh rate range
is greater than 10 Hz.
But we did not check the range in DRM_EDID_FEATURE_CONTINUOUS_FREQ
case.
[How]
Add a refresh rate range check before set the freesync_capable flag
in DRM_EDID_FEATURE_CONTINUOUS_FREQ case.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com >
Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com >
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com >
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:48:40 -04:00
Tom Chung
6b8487cdf9
drm/amd/display: Reset freesync config before update new state
...
[Why]
Sometimes the new_crtc_state->vrr_infopacket did not sync up with the
current state.
It will affect the update_freesync_state_on_stream() does not update
the state correctly.
[How]
Reset the freesync config before get_freesync_config_for_crtc() to
make sure we have the correct new_crtc_state for VRR.
Reviewed-by: Sun peng Li <sunpeng.li@amd.com >
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com >
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-07-01 16:45:05 -04:00