Christophe JAILLET
fb827efbec
mei: pxp: Keep a const qualifier when calling mei_cldev_send()
...
The API has been fixed in commit 0912ef4855christophe.jaillet@wanadoo.fr >
Link: https://lore.kernel.org/r/23c078181575e65ff660f993bc6eb38753b3d5e7.1689971167.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-07-30 18:15:27 +02:00
Andy Shevchenko
1fb1ea0d9c
mei: Move uuid.h to the MEI namespace
...
There is only a single user of the UUID uAPI, let's make it
part of that user.
The way it's done is to prevent compilation time breakage for
the user space that does
#include <linux/uuid.h>
In the future MEI user space tools can switch over to use mei_uuid.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20230310170747.22782-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-03-23 17:25:46 +01:00
Andy Shevchenko
503b676dde
mei: pxp: Use correct macros to initialize uuid_le
...
GUID_INIT() is for internal guid_t type and shouldn't be used
for the uuid_le. I.o.w. relying on the implementation details
is layering violation. Use correct macros to initialize uuid_le.
Fixes: c2004ce99eandriy.shevchenko@linux.intel.com >
Acked-by: Tomas Winkler <tomas.winkler@intel.com >
Link: https://lore.kernel.org/r/20221228160558.21311-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-20 13:07:06 +01:00
Tomas Winkler
bd58904a32
mei: pxp: support matching with a gfx discrete card
...
With on-boards graphics card, both i915 and MEI
are in the same device hierarchy with the same parent,
while for discrete gfx card the MEI is its child device.
Adjust the match function for that scenario
by matching MEI parent device with i915.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com >
Cc: Vitaly Lubart <vitaly.lubart@intel.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com >
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20220928004145.745803-7-daniele.ceraolospurio@intel.com
2022-10-03 11:29:12 -07:00
Vitaly Lubart
c72891256a
mei: pxp: add command streamer API to the PXP driver
...
The discrete graphics card with GSC firmware
using command streamer API hence it requires to enhance
pxp module with the new gsc_command() handler.
The handler is implemented via mei_pxp_gsc_command() which is
just a thin wrapper around mei_cldev_send_gsc_command()
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com >
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com >
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20220928004145.745803-6-daniele.ceraolospurio@intel.com
2022-10-03 11:29:11 -07:00
Won Chung
84d4333c1e
misc/mei: Add NULL check to component match callback functions
...
Currently, component_match callback functions used in mei refers to the
driver name, assuming that the component device being matched has a
driver bound. It can cause a NULL pointer dereference when a device
without a driver bound registers a component. This is due to the nature
of the component framework where all registered components are matched
in any component_match callback functions. So even if a component is
registered by a totally irrelevant device, that component is also
shared to these callbacks for i915 driver.
To prevent totally irrelevant device being matched for i915 and causing
a NULL pointer dereference for checking driver name, add a NULL check on
dev->driver to check if there is a driver bound before checking the
driver name.
In the future, the string compare on the driver name, "i915" may need to
be refactored too.
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com >
Reviewed-by: Prashant Malani <pmalani@chromium.org >
Signed-off-by: Won Chung <wonchung@google.com >
Acked-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com >
2022-04-29 12:17:22 +03:00
Vitaly Lubart
c2004ce99e
mei: pxp: export pavp client to me client bus
...
Export PAVP client to work with i915 driver,
for binding it uses kernel component framework.
v2:drop debug prints, refactor match code to match mei_hdcp (Tomas)
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com >
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com >
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20210924191452.1539378-3-alan.previn.teres.alexis@intel.com
2021-10-04 13:10:17 -04:00
