Christophe JAILLET
d645148cc8
dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function
...
'disable_xdmac()' should be called in the error handling path of the
probe function to undo a previous 'enable_xdmac()' call, as already
done in the remove function.
Fixes: a6e9be055dchristophe.jaillet@wanadoo.fr >
Link: https://lore.kernel.org/r/20201219132800.183254-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2020-12-29 10:08:00 +05:30
Barry Song
280e7f90d4
dmaengine: milbeaut-xdmac: remove redundant irqsave and irqrestore in hardIRQ
...
Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com >
Link: https://lore.kernel.org/r/20201027215252.25820-6-song.bao.hua@hisilicon.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2020-11-09 17:25:54 +05:30
Gustavo A. R. Silva
466f966b1f
dmaengine: Replace zero-length array with flexible-array
...
There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://github.com/KSPP/linux/issues/21
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
2020-06-15 23:08:30 -05:00
Vinod Koul
cdc3e30623
dmaengine: milbeaut-xdmac: remove redundant error log
...
platform_get_irq() prints the error message, so caller need not do so,
remove the error line in this driver for platform_get_irq()
Reported-by: kbuild test robot <lkp@intel.com >
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Link: https://lore.kernel.org/r/20191106163128.1980714-2-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2019-11-08 09:26:17 +05:30
Jassi Brar
a6e9be055d
dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms
...
Driver for Socionext Milbeaut XDMAC controller. The controller only
supports Mem-To-Mem transfers over upto 8 configurable channels.
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org >
Link: https://lore.kernel.org/r/20191015033219.14713-1-jassisinghbrar@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2019-10-18 13:32:18 +05:30
