Andi Shyti
9d8b7b6102
i2c: lpc2k: Use devm_clk_get_enabled()
...
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(),
with a single function devm_clk_get_enabled().
Signed-off-by: Andi Shyti <andi.shyti@kernel.org >
Signed-off-by: Wolfram Sang <wsa@kernel.org >
2023-06-23 12:16:21 +02:00
Uwe Kleine-König
e190a0c389
i2c: Convert to platform remove callback returning void
...
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Acked-by: Alain Volmat <alain.volmat@foss.st.com >
Acked-by: Ard Biesheuvel <ardb@kernel.org >
Acked-by: Baruch Siach <baruch@tkos.co.il >
Acked-by: Florian Fainelli <f.fainelli@gmail.com >
Acked-by: Heiko Stuebner <heiko@sntech.de >
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com >
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com >
Acked-by: Jochen Friedrich <jochen@scram.de >
Acked-by: Peter Rosin <peda@axentia.se >
Acked-by: Vadim Pasternak <vadimp@nvidia.com >
Reviewed-by: Asmaa Mnebhi <asnaa@nvidia.com >
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org >
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz >
Reviewed-by: Chris Pringle <chris.pringle@phabrix.com >
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Reviewed-by: Conor Dooley <conor.dooley@microchip.com >
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be >
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Reviewed-by: Jean Delvare <jdelvare@suse.de >
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org >
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Reviewed-by: Linus Walleij <linus.walleij@linaro.org >
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com >
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com >
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com >
Reviewed-by: Tali Perry <tali.perry@nuvoton.com >
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com >
Signed-off-by: Wolfram Sang <wsa@kernel.org >
2023-06-05 09:47:37 +02:00
Wolfram Sang
ea1558ce14
i2c: move drivers from strlcpy to strscpy
...
Follow the advice of the below link and prefer 'strscpy'. Conversion is
easy because no driver used the return value and has been done with a
simple sed invocation.
Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com >
Signed-off-by: Wolfram Sang <wsa@kernel.org >
2022-08-11 23:02:51 +02:00
Dejin Zheng
e42688ed5c
i2c: busses: remove duplicate dev_err()
...
it will print an error message by itself when platform_get_irq()
goes wrong. so don't need dev_err() in here again.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Suggested-by: Markus Elfring <Markus.Elfring@web.de >
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2020-04-18 23:42:14 +02:00
Dejin Zheng
e0442d7621
i2c: busses: convert to devm_platform_ioremap_resource
...
use devm_platform_ioremap_resource() to simplify code, it
contains platform_get_resource and devm_ioremap_resource.
Reviewed-by: Barry Song <baohua@kernel.org >
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com >
Acked-by: Robert Richter <rrichter@marvell.com >
Acked-by: Thor Thayer <thor.thayer@linux.intel.com >
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2020-04-15 12:09:09 +02:00
Andy Shevchenko
90224e6468
i2c: drivers: Use generic definitions for bus frequencies
...
Since we have generic definitions for bus frequencies, let's use them.
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de >
Acked-by: Robert Richter <rrichter@marvell.com >
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com >
Acked-by: Elie Morisse <syniurge@gmail.com >
Acked-by: Nehal Shah <nehal-bakulchandra.shah@amd.com >
Reviewed-by: Brendan Higgins <brendanhiggins@google.com >
Acked-by: Scott Branden <scott.branden@broadcom.com >
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com >
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com >
Acked-by: Baruch Siach <baruch@tkos.co.il >
Reviewed-by: Guenter Roeck <linux@roeck-us.net >
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de >
Acked-by: Vladimir Zapolskiy <vz@mleia.com >
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com >
Reviewed-by: Linus Walleij <linus.walleij@linaro.org >
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org >
Reviewed-by: Chris Brandt <chris.brandt@renesas.com >
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com >
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com >
Acked-by: Patrice Chotard <patrice.chotard@st.com >
Acked-by: Ard Biesheuvel <ardb@kernel.org >
Reviewed-by: Dmitry Osipenko <digetx@gmail.com >
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2020-03-24 22:36:59 +01:00
Thomas Gleixner
2874c5fd28
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
...
Based on 1 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license as published by
the free software foundation either version 2 of the license or at
your option any later version
extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-or-later
has been chosen to replace the boilerplate/reference in 3029 file(s).
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Reviewed-by: Allison Randal <allison@lohutok.net >
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-05-30 11:26:32 -07:00
Masahiro Yamada
9242e72aae
i2c: use dev_get_drvdata() to get private data in suspend/resume hooks
...
Several drivers call to_platform_device() to get platform_device
and pass it to platform_get_drvdata(). In platform_get_drvdata(),
the platform_device is converted back to struct device again.
Use dev_get_drvdata() to avoid platform_device/device dance.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com > (for DesignWare only)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2017-07-31 17:03:32 +02:00
Wolfram Sang
ea734404f3
i2c: don't print error when adding adapter fails
...
The core will do this for us now.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com >
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com >
Acked-by: Peter Korsgaard <peter@korsgaard.com >
Acked-by: Heiko Stuebner <heiko@sntech.de >
Acked-by: Neil Horman <nhorman@tuxdriver.com >
Acked-by: Thierry Reding <treding@nvidia.com >
Acked-by: Ray Jui <ray.jui@broadcom.com >
Acked-by: Vladimir Zapolskiy <vz@mleia.com >
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com >
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com >
Acked-by: Laxman Dewangan <ldewangan@nvidia.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2016-08-22 08:19:55 +02:00
Wolfram Sang
043f47f49b
i2c: lpc2k: use new 8 bit address helper function
...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2016-04-11 18:54:59 +02:00
Joachim Eastwood
3f9c37a0c9
i2c: lpc2k: add driver
...
Add support for the I2C controller found on several NXP devices
including LPC2xxx, LPC178x/7x and LPC18xx/43xx. The controller
is implemented as a state machine and the driver act upon the
state changes when the bus is accessed.
The I2C controller supports master/slave operation, bus
arbitration, programmable clock rate, and speeds up to 1 Mbit/s.
Signed-off-by: Joachim Eastwood <manabian@gmail.com >
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2015-08-24 14:05:18 +02:00