Colin Ian King
4ceb681f18
platform/x86: hp: hp-bioscfg: remove redundant if statement
...
The if statement performs the same action if the strcmp result is
true or false since there is identical code on both branches. The
if statement is redundant and can be replaced with just one call
to sysfs_remove_group.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com >
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/20241107113543.17137-1-colin.i.king@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
2024-11-12 11:47:40 +02:00
Andy Shevchenko
c5288cda69
platform/x86: hp: hp-bioscfg: Use 2-argument strscpy()
...
Use 2-argument strscpy(), which is not only shorter but also provides
an additional check that destination buffer is an array.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com >
Link: https://lore.kernel.org/r/20240602090244.1666360-3-andy.shevchenko@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
2024-06-03 14:51:36 +03:00
Tanzir Hasan
810bad6e05
platform/x86: hp-bioscfg: Removed needless asm-generic
...
asm-generic/posix-types.h is obtained through bioscfg.h so there is no
need to include it. It is also an asm-generic file which should be
avoided if possible.
Suggest-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Tanzir Hasan <tanzirh@google.com >
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com >
Tested-by: Nick Desaulniers <ndesaulniers@google.com >
Link: https://lore.kernel.org/r/20231219-hp-password-v1-1-052fe7b6b7f1@google.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-12-28 10:06:44 +01:00
Jorge Lopez
efd4211e54
platform/x86: hp-bioscfg: Change how password encoding size is evaluated
...
Update steps how password encoding size is evaluated
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-8-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:35:30 +02:00
Jorge Lopez
08f1f21257
platform/x86: hp-bioscfg: Change how prerequisites size is evaluated
...
Update steps taken to evaluate prerequisites size value
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-5-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:46 +02:00
Jorge Lopez
a585400b36
platform/x86: hp-bioscfg: Replace the word HACK from source code
...
Replace the word 'HACK' with 'step' from source code
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-4-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:42 +02:00
Jorge Lopez
80d7ba3020
platform/x86: hp-bioscfg: Fix uninitialized variable errors
...
Fix uninitialized variable errors.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-3-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:38 +02:00
Jorge Lopez
467d416381
platform/x86: hp-bioscfg: Fix memory leaks in attribute packages
...
Address memory leaks while handling elements in packages.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-2-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:30 +02:00
Jorge Lopez
8646a3b5ee
platform/x86: hp-bioscfg: passwdobj-attributes
...
Add authentication attributes support to hp-bioscfg.
HP BIOS Configuration driver purpose is to provide a driver supporting
the latest sysfs class firmware attributes framework allowing the user
to change BIOS settings and security solutions on HP Inc.’s commercial
notebooks.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net >
Link: https://lore.kernel.org/r/20230608163319.18934-9-jorge.lopez2@hp.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-10 14:41:28 +02:00
