3 Commits

Author	SHA1	Message	Date
Dan Carpenter	d4e695c016	platform/x86: hp-bioscfg: fix error reporting in hp_add_other_attributes() ... Return a negative error code instead of returning success. Fixes: a34fc329b1 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/138641cc-52c0-41a5-8176-ad01c7e28c67@moroto.mountain Reviewed-by: Jorge Lopez <jorge.lopez2@hp.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>	2023-07-26 16:16:42 +02:00
Dan Carpenter	b3a8692d2c	platform/x86: hp-bioscfg: prevent a small buffer overflow ... This function escapes certain special characters like \n. So if the last character in the string is a '\n' then it gets changed into two characters '\' and '\n'. But maybe we only have space for the '\' so we need to check for that. The "conv_dst_size" variable is always less than or to equal the "size" variable. It's easier to just check "conv_dst_size" instead of checking both. Fixes: a34fc329b1 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/b4950310-e65f-412f-8d2b-90bb074a6572@moroto.mountain Reviewed-by: Jorge Lopez <jorge.lopez2@hp.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>	2023-07-26 16:16:22 +02:00
Jorge Lopez	a34fc329b1	platform/x86: hp-bioscfg: bioscfg ... Add common functions support to hp-bioscfg. HP BIOS Configuration driver purpose is to provide a driver supporting the latest sysfs class firmware attributes framework allowing the user to change BIOS settings and security solutions on HP Inc.’s commercial notebooks. Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://lore.kernel.org/r/20230608163319.18934-4-jorge.lopez2@hp.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>	2023-07-10 14:41:27 +02:00