Yihan Zhu
9bdcf2a5c6
drm/amd/display: w/a to program DISPCLK_R_GATE_DISABLE DCN35
...
[WHY & HOW]
Cursor corruption observed on USBC display with specific system setup with a
reboot. Cursor memory might still in the lightsleep state due to voltage
issue, we need program DISPCLK_R_GATE_DISABLE to avoid this issue only on
DCN35.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com >
Signed-off-by: Yihan Zhu <Yihan.Zhu@amd.com >
Signed-off-by: Wayne Lin <wayne.lin@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-10-22 17:50:38 -04:00
Ivan Lipski
223ac8b6f5
drm/amd/display: Remove redundant if conditions
...
[WHY]
Coverity analysis flagged the two if conditions in
dcn30_dpp.c and dcn401_dpp.c as DEADCODE since they
are never true, since the variable
'program_prealpha_dealpha' is initialized at 0 and
never chagnes.
[HOW]
Removed the variable 'program_prealpha_dealpha' and
the if conditions.
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com >
Signed-off-by: Ivan Lipski <ivlipski@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-06-14 16:17:13 -04:00
Nicholas Kazlauskas
470679ef33
drm/amd/display: Guard reading 3DLUT registers for dcn32/dcn35
...
[Why]
3DLUT is not part of the DPP on DCN32/DCN35 ASIC and these registers
now exist in MCM state.
[How]
Add guards when reading DPP state based on whether the register has a
valid offset.
Reviewed-by: Sung joon Kim <sungjoon.kim@amd.com >
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com >
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-06-14 15:34:52 -04:00
Wayne Lin
9e9ad05631
drm/amd/display: Remove unnecessary files
...
[Why & How]
We accidentally upstream unnecessary files. Remove them.
Reviewed-by: Tom Chung <chiahsuan.chung@amd.com >
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-30 09:52:21 -04:00
Aurabindo Pillai
00c391102a
drm/amd/display: Add misc DC changes for DCN401
...
Add miscellaneous changes to enable DCN401 init
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com >
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-26 17:23:34 -04:00
Alex Hung
ba3193fa8f
drm/amd/display: Fix uninitialized variables in DC
...
This fixes 49 UNINIT issues reported by Coverity.
Reviewed-by: Hersen Wu <hersenxs.wu@amd.com >
Acked-by: Wayne Lin <wayne.lin@amd.com >
Signed-off-by: Alex Hung <alex.hung@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-26 17:22:44 -04:00
Rodrigo Siqueira
d9fbd64e8e
Revert "drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled"
...
This reverts commit 002001b092 .
The original patch introduces cursor gamma issue to multiple
Linux compositors. For this reason this commit reverts this change.
Cc: Melissa Wen <mwen@igalia.com >
Cc: Harry Wentland <harry.wentland@amd.com >
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com >
Reviewed-by: Melissa Wen <mwen@igalia.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-16 22:39:15 -04:00
Rodrigo Siqueira
e7927b2914
drm/amd/display: Add some missing debug registers
...
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com >
Acked-by: Roman Li <roman.li@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-09 22:05:50 -04:00
Rodrigo Siqueira
002001b092
drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled
...
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com >
Acked-by: Roman Li <roman.li@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-09 22:05:42 -04:00
Rodrigo Siqueira
916635b98d
drm/amd/display: Set alpha enable to 0 for some specific formats
...
Set alpha_en to 0 in some specific color formats.
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com >
Acked-by: Roman Li <roman.li@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-04-09 22:05:34 -04:00
Alvin Lee
285a7054bf
drm/amd/display: Remove plane and stream pointers from dc scratch
...
[Why&How]
Remove several plane and stream pointers from dc for code
refactoring.
Reviewed-by: Wenjing Liu <wenjing.liu@amd.com >
Acked-by: Tom Chung <chiahsuan.chung@amd.com >
Signed-off-by: Alvin Lee <alvin.lee2@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-03-27 01:43:22 -04:00
Revalla Hari Krishna
8886780756
drm/amd/display: Refactor DPP into a component directory
...
[WHY & HOW]
Move all dpp files to a new dpp directory.
Reviewed-by: Martin Leung <martin.leung@amd.com >
Acked-by: Alex Hung <alex.hung@amd.com >
Signed-off-by: Revalla Hari Krishna <harikrishna.revalla@amd.com >
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2024-03-20 13:37:37 -04:00