Stefan Dösinger
082d9e263a
wifi: brcmfmac: Check the return value of of_property_read_string_index()
Somewhen between 6.10 and 6.11 the driver started to crash on my
MacBookPro14,3. The property doesn't exist and 'tmp' remains
uninitialized, so we pass a random pointer to devm_kstrdup().
The crash I am getting looks like this:
BUG: unable to handle page fault for address: 00007f033c669379
PF: supervisor read access in kernel mode
PF: error_code(0x0001) - permissions violation
PGD 8000000101341067 P4D 8000000101341067 PUD 101340067 PMD 1013bb067 PTE 800000010aee9025
Oops: Oops: 0001 [#1] SMP PTI
CPU: 4 UID: 0 PID: 827 Comm: (udev-worker) Not tainted 6.11.8-gentoo #1
Hardware name: Apple Inc. MacBookPro14,3/Mac-551B86E5744E2388, BIOS 529.140.2.0.0 06/23/2024
RIP: 0010:strlen+0x4/0x30
Code: f7 75 ec 31 c0 c3 cc cc cc cc 48 89 f8 c3 cc cc cc cc 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa <80> 3f 00 74 14 48 89 f8 48 83 c0 01 80 38 00 75 f7 48 29 f8 c3 cc
RSP: 0018:ffffb4aac0683ad8 EFLAGS: 00010202
RAX: 00000000ffffffea RBX: 00007f033c669379 RCX: 0000000000000001
RDX: 0000000000000cc0 RSI: 00007f033c669379 RDI: 00007f033c669379
RBP: 00000000ffffffea R08: 0000000000000000 R09: 00000000c0ba916a
R10: ffffffffffffffff R11: ffffffffb61ea260 R12: ffff91f7815b50c8
R13: 0000000000000cc0 R14: ffff91fafefffe30 R15: ffffb4aac0683b30
FS: 00007f033ccbe8c0(0000) GS:ffff91faeed00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f033c669379 CR3: 0000000107b1e004 CR4: 00000000003706f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
? __die+0x23/0x70
? page_fault_oops+0x149/0x4c0
? raw_spin_rq_lock_nested+0xe/0x20
? sched_balance_newidle+0x22b/0x3c0
? update_load_avg+0x78/0x770
? exc_page_fault+0x6f/0x150
? asm_exc_page_fault+0x26/0x30
? __pfx_pci_conf1_write+0x10/0x10
? strlen+0x4/0x30
devm_kstrdup+0x25/0x70
brcmf_of_probe+0x273/0x350 [brcmfmac]
Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20250106170958.3595-1-stefan@codeweavers.com
2025-01-10 14:53:04 +02:00
..
2024-12-20 07:13:45 +10:00
2024-11-04 17:53:09 +09:00
2024-12-18 20:23:59 +01:00
2024-11-12 16:41:45 +00:00
2024-11-29 11:58:27 -08:00
2024-12-09 09:06:58 +09:00
2024-12-01 15:12:43 -08:00
2024-12-20 07:13:45 +10:00
2024-12-08 11:38:56 -08:00
2024-12-01 15:12:43 -08:00
2024-12-28 11:02:35 -08:00
2025-01-08 11:14:03 -05:00
2024-11-29 11:58:27 -08:00
2024-12-30 12:56:06 -07:00
2024-12-03 08:22:25 -08:00
2024-12-01 15:12:43 -08:00
2025-01-05 10:28:34 -08:00
2024-12-09 18:42:42 +00:00
2024-11-05 14:01:07 +01:00
2024-12-02 11:34:44 -08:00
2024-12-10 10:17:43 -06:00
2024-12-01 15:12:43 -08:00
2024-12-10 13:40:25 +08:00
2024-12-10 14:50:34 -07:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-26 10:43:25 -08:00
2024-12-20 07:13:45 +10:00
2024-11-03 08:39:07 -08:00
2024-12-11 21:47:33 +01:00
2024-12-01 15:12:43 -08:00
2024-11-25 17:12:54 -08:00
2024-12-21 15:45:06 -08:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-10 11:38:57 +01:00
2025-01-03 10:57:31 +10:00
2024-11-05 05:33:46 +01:00
2024-12-05 10:06:47 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-09 18:44:15 +00:00
2024-12-16 15:58:25 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-26 01:54:47 +01:00
2024-12-01 15:12:43 -08:00
2024-11-11 15:48:50 +01:00
2024-12-08 11:26:13 -08:00
2025-01-03 16:29:29 -08:00
2024-11-25 10:31:39 -08:00
2024-11-05 01:32:05 +02:00
2024-12-13 15:54:27 +01:00
2024-12-13 18:15:29 +01:00
2024-12-11 20:12:27 -08:00
2024-12-02 11:34:44 -08:00
2024-12-20 07:13:45 +10:00
2024-11-30 09:03:16 -08:00
2024-12-02 11:34:44 -08:00
2025-01-08 10:12:01 -08:00
2024-12-21 10:56:34 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-11-20 21:38:24 -05:00
2024-12-02 11:34:44 -08:00
2024-12-02 11:34:44 -08:00
2024-12-19 14:42:10 +01:00
2024-12-05 11:15:00 +01:00
2025-01-10 14:53:04 +02:00
2025-01-06 16:49:29 -08:00
2024-10-30 16:07:38 -05:00
2024-12-02 11:34:44 -08:00
2024-12-31 10:41:58 -07:00
2024-12-01 15:12:43 -08:00
2024-12-22 08:40:23 -08:00
2024-11-27 14:40:33 -08:00
2024-12-01 15:12:43 -08:00
2024-12-01 15:12:43 -08:00
2024-12-29 10:03:01 -08:00
2024-12-01 15:12:43 -08:00
2024-12-02 11:34:44 -08:00
2024-12-02 11:34:44 -08:00
2024-12-24 20:38:53 +05:30
2025-01-03 10:57:57 -08:00
2024-12-30 11:20:42 -08:00
2024-12-19 15:47:02 +01:00
2024-12-19 00:35:30 +01:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-11-15 00:32:29 +11:00
2025-01-02 17:10:27 -08:00
2024-12-19 08:50:05 -08:00
2024-12-19 11:15:24 +00:00
2024-11-15 20:36:27 -08:00
2024-12-02 11:34:44 -08:00
2024-12-01 15:12:43 -08:00
2024-12-02 11:34:44 -08:00
2024-11-29 11:43:29 -08:00
2024-12-01 15:12:43 -08:00
2024-12-04 13:22:59 -05:00
2024-11-30 14:45:29 -08:00
2024-12-01 15:12:43 -08:00
2024-11-21 08:28:08 -08:00
2024-12-02 11:34:44 -08:00
2024-12-18 16:02:08 +00:00
2024-12-01 15:12:43 -08:00
2025-01-03 16:29:29 -08:00
2024-12-02 12:36:18 -05:00
2024-11-12 15:48:08 +01:00
2024-12-01 15:12:43 -08:00
2024-12-18 14:51:31 +01:00
2024-12-16 09:59:38 +02:00
2024-12-14 09:31:19 -08:00
2025-01-02 13:00:16 -05:00
2024-12-01 15:12:43 -08:00
2024-12-17 11:59:09 +01:00
2024-12-23 10:34:45 -08:00
2025-01-03 08:49:05 -07:00
2024-11-11 10:56:27 -08:00
2024-12-20 07:13:45 +10:00
2024-12-29 10:18:44 +01:00
2024-12-10 11:22:21 +01:00
2024-12-01 15:12:43 -08:00
2024-12-30 15:28:02 +01:00
2024-12-02 11:34:44 -08:00