Files
linux/include/linux
Willy Tarreau 5c9a9508de proc: do not access cmdline nor environ from file-backed areas
commit 7f7ccc2ccc upstream.

proc_pid_cmdline_read() and environ_read() directly access the target
process' VM to retrieve the command line and environment. If this
process remaps these areas onto a file via mmap(), the requesting
process may experience various issues such as extra delays if the
underlying device is slow to respond.

Let's simply refuse to access file-backed areas in these functions.
For this we add a new FOLL_ANON gup flag that is passed to all calls
to access_remote_vm(). The code already takes care of such failures
(including unmapped areas). Accesses via /proc/pid/mem were not
changed though.

This was assigned CVE-2018-1120.

Note for stable backports: the patch may apply to kernels prior to 4.11
but silently miss one location; it must be checked that no call to
access_remote_vm() keeps zero as the last argument.

Reported-by: Qualys Security Advisory <qsa@qualys.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-05-19 10:20:27 +02:00
..
2018-04-24 09:36:39 +02:00
2017-12-29 17:53:47 +01:00
2017-12-25 14:26:33 +01:00
2018-02-22 15:42:23 +01:00
2017-08-30 14:40:40 +02:00
2018-01-17 09:45:27 +01:00
2017-08-24 13:23:03 -07:00
2018-02-22 15:42:23 +01:00
2017-08-03 19:09:26 -07:00
2017-08-07 17:22:14 +02:00
2018-02-22 15:42:23 +01:00
2018-02-22 15:42:24 +01:00
2017-08-15 18:23:52 +02:00
2017-08-14 13:33:39 -07:00
2017-08-28 20:51:22 +02:00
2017-09-07 11:53:11 +02:00
2018-02-22 15:42:23 +01:00
2018-02-22 15:42:23 +01:00
2017-09-25 08:56:05 -06:00
2017-08-06 20:55:29 -07:00
2018-02-22 15:42:23 +01:00
2017-08-16 16:28:47 -07:00
2018-02-22 15:42:23 +01:00
2017-08-31 18:50:14 +02:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00