mirror of
https://github.com/torvalds/linux.git
synced 2026-04-24 17:42:27 -04:00
ec7727bb24
the following script:
# tc qdisc add dev crash0 clsact
# tc filter add dev crash0 egress matchall \
> action skbedit ptype host pass index 90
# tc actions replace action skbedit \
> ptype host goto chain 42 index 90 cookie c1a0c1a0
# tc actions show action skbedit
had the following output:
Error: Failed to init TC action chain.
We have an error talking to the kernel
total acts 1
action order 0: skbedit ptype host goto chain 42
index 90 ref 2 bind 1
cookie c1a0c1a0
Then, the first packet transmitted by crash0 made the kernel crash:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
#PF error: [normal kernel read fault]
PGD 0 P4D 0
Oops: 0000 [#1] SMP PTI
CPU: 3 PID: 3467 Comm: kworker/3:3 Not tainted 5.0.0-rc4.gotochain_crash+ #536
Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
Workqueue: ipv6_addrconf addrconf_dad_work
RIP: 0010:tcf_action_exec+0xb8/0x100
Code: 00 00 00 20 74 1d 83 f8 03 75 09 49 83 c4 08 4d 39 ec 75 bc 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 49 8b 97 a8 00 00 00 <48> 8b 12 48 89 55 00 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3
RSP: 0018:ffffb50a81e1fad0 EFLAGS: 00010246
RAX: 000000002000002a RBX: ffff9aa47ba4ea00 RCX: 0000000000000001
RDX: 0000000000000000 RSI: ffff9aa469eeb3c0 RDI: ffff9aa47ba4ea00
RBP: ffffb50a81e1fb70 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: ffff9aa47bce0638 R12: ffff9aa4793b0c00
R13: ffff9aa4793b0c08 R14: 0000000000000001 R15: ffff9aa469eeb3c0
FS: 0000000000000000(0000) GS:ffff9aa474780000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 000000007360e005 CR4: 00000000001606e0
Call Trace:
tcf_classify+0x58/0x120
__dev_queue_xmit+0x40a/0x890
? ndisc_next_option+0x50/0x50
? ___neigh_create+0x4d5/0x680
? ip6_finish_output2+0x1b5/0x590
ip6_finish_output2+0x1b5/0x590
? ip6_output+0x68/0x110
ip6_output+0x68/0x110
? nf_hook.constprop.28+0x79/0xc0
ndisc_send_skb+0x248/0x2e0
ndisc_send_ns+0xf8/0x200
? addrconf_dad_work+0x389/0x4b0
addrconf_dad_work+0x389/0x4b0
? __switch_to_asm+0x34/0x70
? process_one_work+0x195/0x380
? addrconf_dad_completed+0x370/0x370
process_one_work+0x195/0x380
worker_thread+0x30/0x390
? process_one_work+0x380/0x380
kthread+0x113/0x130
? kthread_park+0x90/0x90
ret_from_fork+0x35/0x40
Modules linked in: act_skbedit veth ip6table_filter ip6_tables iptable_filter binfmt_misc crct10dif_pclmul crc32_pclmul ghash_clmulni_intel ext4 snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep mbcache snd_hda_core jbd2 snd_seq snd_seq_device snd_pcm aesni_intel crypto_simd cryptd snd_timer glue_helper snd joydev soundcore pcspkr virtio_balloon i2c_piix4 nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs ata_generic pata_acpi qxl drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm virtio_net net_failover drm failover virtio_blk virtio_console ata_piix virtio_pci crc32c_intel serio_raw libata virtio_ring virtio floppy dm_mirror dm_region_hash dm_log dm_mod
CR2: 0000000000000000
Validating the control action within tcf_skbedit_init() proved to fix the
above issue. A TDC selftest is added to verify the correct behavior.
Fixes: db50514f9a ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f4 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
514 lines
15 KiB
JSON
514 lines
15 KiB
JSON
[
|
|
{
|
|
"id": "6236",
|
|
"name": "Add skbedit action with valid mark",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit mark 1",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit mark 1",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "407b",
|
|
"name": "Add skbedit action with invalid mark",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit mark 666777888999",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit mark",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "081d",
|
|
"name": "Add skbedit action with priority",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit prio 99",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit priority :99",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "cc37",
|
|
"name": "Add skbedit action with invalid priority",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit prio foo",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit priority",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "3c95",
|
|
"name": "Add skbedit action with queue_mapping",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit queue_mapping 909",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit queue_mapping 909",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "985c",
|
|
"name": "Add skbedit action with invalid queue_mapping",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit queue_mapping 67000",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit queue_mapping",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "224f",
|
|
"name": "Add skbedit action with ptype host",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit ptype host",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit ptype host",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "d1a3",
|
|
"name": "Add skbedit action with ptype otherhost",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit ptype otherhost",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit ptype otherhost",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "b9c6",
|
|
"name": "Add skbedit action with invalid ptype",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit ptype openair",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit ptype openair",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "464a",
|
|
"name": "Add skbedit action with control pipe",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit ptype host pipe index 11",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 11",
|
|
"matchPattern": "action order [0-9]*: skbedit ptype host pipe.*index 11 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "212f",
|
|
"name": "Add skbedit action with control reclassify",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit mark 56789 reclassify index 90",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 90",
|
|
"matchPattern": "action order [0-9]*: skbedit mark 56789 reclassify.*index 90 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "0651",
|
|
"name": "Add skbedit action with control pass",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit queue_mapping 3 pass index 271",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 271",
|
|
"matchPattern": "action order [0-9]*: skbedit queue_mapping 3 pass.*index 271 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "cc53",
|
|
"name": "Add skbedit action with control drop",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit queue_mapping 3 drop index 271",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 271",
|
|
"matchPattern": "action order [0-9]*: skbedit queue_mapping 3 drop.*index 271 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "ec16",
|
|
"name": "Add skbedit action with control jump",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit priority 8 jump 9 index 2",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 2",
|
|
"matchPattern": "action order [0-9]*: skbedit priority :8 jump 9.*index 2 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "db54",
|
|
"name": "Add skbedit action with control continue",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit priority 16 continue index 32",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 32",
|
|
"matchPattern": "action order [0-9]*: skbedit priority :16 continue.*index 32 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "1055",
|
|
"name": "Add skbedit action with cookie",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit priority 16 continue index 32 cookie deadbeef",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action skbedit index 32",
|
|
"matchPattern": "action order [0-9]*: skbedit priority :16 continue.*index 32 ref.*cookie deadbeef",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "5172",
|
|
"name": "List skbedit actions",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action skbedit ptype otherhost",
|
|
"$TC actions add action skbedit ptype broadcast",
|
|
"$TC actions add action skbedit mark 59",
|
|
"$TC actions add action skbedit mark 409"
|
|
],
|
|
"cmdUnderTest": "$TC actions list action skbedit",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit",
|
|
"matchCount": "4",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "a6d6",
|
|
"name": "Add skbedit action with index",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action skbedit mark 808 index 4040404040",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "index 4040404040",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "38f3",
|
|
"name": "Delete skbedit action",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action skbedit mark 42 index 9009"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action skbedit index 9009",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit mark 42",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "ce97",
|
|
"name": "Flush skbedit actions",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
"$TC actions add action skbedit mark 500",
|
|
"$TC actions add action skbedit mark 501",
|
|
"$TC actions add action skbedit mark 502",
|
|
"$TC actions add action skbedit mark 503",
|
|
"$TC actions add action skbedit mark 504",
|
|
"$TC actions add action skbedit mark 505",
|
|
"$TC actions add action skbedit mark 506"
|
|
],
|
|
"cmdUnderTest": "$TC actions flush action skbedit",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
},
|
|
{
|
|
"id": "1b2b",
|
|
"name": "Replace skbedit action with invalid goto_chain control",
|
|
"category": [
|
|
"actions",
|
|
"skbedit"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action skbedit",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action skbedit ptype host pass index 90"
|
|
],
|
|
"cmdUnderTest": "$TC actions replace action skbedit ptype host goto chain 42 index 90 cookie c1a0c1a0",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action skbedit",
|
|
"matchPattern": "action order [0-9]*: skbedit ptype host pass.*index 90 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action skbedit"
|
|
]
|
|
}
|
|
]
|