mirror of
https://github.com/torvalds/linux.git
synced 2026-04-24 17:42:27 -04:00
b239d0c238
Extra dtc warnings (roughly what W=1 enables) are now enabled by default
when building the binding examples. These were fixed treewide in
5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
warnings:
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name
Fixing the above, then results in:
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name
Fixes: eadd54c75f ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: alsa-devel@alsa-project.org
Cc: Benson Leung <bleung@chromium.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Link: https://lore.kernel.org/r/20200311205841.2710-1-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
68 lines
1.9 KiB
YAML
68 lines
1.9 KiB
YAML
# SPDX-License-Identifier: GPL-2.0-only
|
|
%YAML 1.2
|
|
---
|
|
$id: http://devicetree.org/schemas/sound/google,cros-ec-codec.yaml#
|
|
$schema: http://devicetree.org/meta-schemas/core.yaml#
|
|
|
|
title: Audio codec controlled by ChromeOS EC
|
|
|
|
maintainers:
|
|
- Cheng-Yi Chiang <cychiang@chromium.org>
|
|
|
|
description: |
|
|
Google's ChromeOS EC codec is a digital mic codec provided by the
|
|
Embedded Controller (EC) and is controlled via a host-command interface.
|
|
An EC codec node should only be found as a sub-node of the EC node (see
|
|
Documentation/devicetree/bindings/mfd/cros-ec.txt).
|
|
|
|
properties:
|
|
compatible:
|
|
const: google,cros-ec-codec
|
|
|
|
"#sound-dai-cells":
|
|
const: 1
|
|
|
|
reg:
|
|
items:
|
|
- description: |
|
|
Physical base address and length of shared memory region from EC.
|
|
It contains 3 unsigned 32-bit integer. The first 2 integers
|
|
combine to become an unsigned 64-bit physical address.
|
|
The last one integer is the length of the shared memory.
|
|
|
|
memory-region:
|
|
$ref: '/schemas/types.yaml#/definitions/phandle'
|
|
description: |
|
|
Shared memory region to EC. A "shared-dma-pool".
|
|
See ../reserved-memory/reserved-memory.txt for details.
|
|
|
|
required:
|
|
- compatible
|
|
- '#sound-dai-cells'
|
|
|
|
additionalProperties: false
|
|
|
|
examples:
|
|
- |
|
|
reserved_mem: reserved-mem@52800000 {
|
|
compatible = "shared-dma-pool";
|
|
reg = <0x52800000 0x100000>;
|
|
no-map;
|
|
};
|
|
spi {
|
|
#address-cells = <1>;
|
|
#size-cells = <0>;
|
|
cros-ec@0 {
|
|
compatible = "google,cros-ec-spi";
|
|
#address-cells = <2>;
|
|
#size-cells = <1>;
|
|
reg = <0>;
|
|
cros_ec_codec: ec-codec@10500000 {
|
|
compatible = "google,cros-ec-codec";
|
|
#sound-dai-cells = <1>;
|
|
reg = <0x0 0x10500000 0x80000>;
|
|
memory-region = <&reserved_mem>;
|
|
};
|
|
};
|
|
};
|