mirror of
https://github.com/torvalds/linux.git
synced 2026-05-01 13:02:35 -04:00
1d409b0a77
Both i915_switcheroo_set_state() and i915_switcheroo_can_switch() check for i915 == NULL. Commitd2e184f8e1("drm/i915/switcheroo: pass display to HAS_DISPLAY()") started dereferencing it before the NULL check. Fix it. Fixes:d2e184f8e1("drm/i915/switcheroo: pass display to HAS_DISPLAY()") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202508160035.hmzuKiww-lkp@intel.com/ Cc: Gustavo Sousa <gustavo.sousa@intel.com> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com> Link: https://lore.kernel.org/r/20250818071605.2541523-1-jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
77 lines
2.2 KiB
C
77 lines
2.2 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/vga_switcheroo.h>
|
|
|
|
#include "display/intel_display_core.h"
|
|
|
|
#include "i915_driver.h"
|
|
#include "i915_drv.h"
|
|
#include "i915_switcheroo.h"
|
|
|
|
static void i915_switcheroo_set_state(struct pci_dev *pdev,
|
|
enum vga_switcheroo_state state)
|
|
{
|
|
struct drm_i915_private *i915 = pdev_to_i915(pdev);
|
|
struct intel_display *display = i915 ? i915->display : NULL;
|
|
pm_message_t pmm = { .event = PM_EVENT_SUSPEND };
|
|
|
|
if (!i915) {
|
|
dev_err(&pdev->dev, "DRM not initialized, aborting switch.\n");
|
|
return;
|
|
}
|
|
if (!HAS_DISPLAY(display)) {
|
|
dev_err(&pdev->dev, "Device state not initialized, aborting switch.\n");
|
|
return;
|
|
}
|
|
|
|
if (state == VGA_SWITCHEROO_ON) {
|
|
drm_info(&i915->drm, "switched on\n");
|
|
i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
|
|
/* i915 resume handler doesn't set to D0 */
|
|
pci_set_power_state(pdev, PCI_D0);
|
|
i915_driver_resume_switcheroo(i915);
|
|
i915->drm.switch_power_state = DRM_SWITCH_POWER_ON;
|
|
} else {
|
|
drm_info(&i915->drm, "switched off\n");
|
|
i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
|
|
i915_driver_suspend_switcheroo(i915, pmm);
|
|
i915->drm.switch_power_state = DRM_SWITCH_POWER_OFF;
|
|
}
|
|
}
|
|
|
|
static bool i915_switcheroo_can_switch(struct pci_dev *pdev)
|
|
{
|
|
struct drm_i915_private *i915 = pdev_to_i915(pdev);
|
|
struct intel_display *display = i915 ? i915->display : NULL;
|
|
|
|
/*
|
|
* FIXME: open_count is protected by drm_global_mutex but that would lead to
|
|
* locking inversion with the driver load path. And the access here is
|
|
* completely racy anyway. So don't bother with locking for now.
|
|
*/
|
|
return i915 && HAS_DISPLAY(display) && atomic_read(&i915->drm.open_count) == 0;
|
|
}
|
|
|
|
static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {
|
|
.set_gpu_state = i915_switcheroo_set_state,
|
|
.reprobe = NULL,
|
|
.can_switch = i915_switcheroo_can_switch,
|
|
};
|
|
|
|
int i915_switcheroo_register(struct drm_i915_private *i915)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
|
|
|
|
return vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
|
|
}
|
|
|
|
void i915_switcheroo_unregister(struct drm_i915_private *i915)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
|
|
|
|
vga_switcheroo_unregister_client(pdev);
|
|
}
|