mirror of
https://github.com/torvalds/linux.git
synced 2026-04-30 04:22:32 -04:00
d5c7533a46
Include <linux/io.h> to get readl() and writel() on S390. The error
message is shown below and a bug report is at [1].
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c:75:15: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
75 | reg = readl(priv->mmio + HIBMC_DISPLAY_CONTROL_HISILE);
| ^~~~~
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c:80:9: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
80 | writel(reg, priv->mmio + HIBMC_DISPLAY_CONTROL_HISILE);
| ^~~~~~
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 45b64fd9f7 ("drm/fb-helper: Remove unnecessary include statements")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Link: https://lore.kernel.org/dri-devel/202211060608.qrTg8b2E-lkp@intel.com/T/#u # [1]
Link: https://patchwork.freedesktop.org/patch/msgid/20221107125329.12842-3-tzimmermann@suse.de
128 lines
3.5 KiB
C
128 lines
3.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/* Hisilicon Hibmc SoC drm driver
|
|
*
|
|
* Based on the bochs drm driver.
|
|
*
|
|
* Copyright (c) 2016 Huawei Limited.
|
|
*
|
|
* Author:
|
|
* Rongrong Zou <zourongrong@huawei.com>
|
|
* Rongrong Zou <zourongrong@gmail.com>
|
|
* Jianhua Li <lijianhua@huawei.com>
|
|
*/
|
|
|
|
#include <linux/io.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <drm/drm_print.h>
|
|
#include <drm/drm_simple_kms_helper.h>
|
|
|
|
#include "hibmc_drm_drv.h"
|
|
#include "hibmc_drm_regs.h"
|
|
|
|
static int hibmc_connector_get_modes(struct drm_connector *connector)
|
|
{
|
|
int count;
|
|
void *edid;
|
|
struct hibmc_connector *hibmc_connector = to_hibmc_connector(connector);
|
|
|
|
edid = drm_get_edid(connector, &hibmc_connector->adapter);
|
|
if (edid) {
|
|
drm_connector_update_edid_property(connector, edid);
|
|
count = drm_add_edid_modes(connector, edid);
|
|
if (count)
|
|
goto out;
|
|
}
|
|
|
|
count = drm_add_modes_noedid(connector,
|
|
connector->dev->mode_config.max_width,
|
|
connector->dev->mode_config.max_height);
|
|
drm_set_preferred_mode(connector, 1024, 768);
|
|
|
|
out:
|
|
kfree(edid);
|
|
return count;
|
|
}
|
|
|
|
static void hibmc_connector_destroy(struct drm_connector *connector)
|
|
{
|
|
struct hibmc_connector *hibmc_connector = to_hibmc_connector(connector);
|
|
|
|
i2c_del_adapter(&hibmc_connector->adapter);
|
|
drm_connector_cleanup(connector);
|
|
}
|
|
|
|
static const struct drm_connector_helper_funcs
|
|
hibmc_connector_helper_funcs = {
|
|
.get_modes = hibmc_connector_get_modes,
|
|
};
|
|
|
|
static const struct drm_connector_funcs hibmc_connector_funcs = {
|
|
.fill_modes = drm_helper_probe_single_connector_modes,
|
|
.destroy = hibmc_connector_destroy,
|
|
.reset = drm_atomic_helper_connector_reset,
|
|
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
|
|
};
|
|
|
|
static void hibmc_encoder_mode_set(struct drm_encoder *encoder,
|
|
struct drm_display_mode *mode,
|
|
struct drm_display_mode *adj_mode)
|
|
{
|
|
u32 reg;
|
|
struct drm_device *dev = encoder->dev;
|
|
struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
|
|
|
|
reg = readl(priv->mmio + HIBMC_DISPLAY_CONTROL_HISILE);
|
|
reg |= HIBMC_DISPLAY_CONTROL_FPVDDEN(1);
|
|
reg |= HIBMC_DISPLAY_CONTROL_PANELDATE(1);
|
|
reg |= HIBMC_DISPLAY_CONTROL_FPEN(1);
|
|
reg |= HIBMC_DISPLAY_CONTROL_VBIASEN(1);
|
|
writel(reg, priv->mmio + HIBMC_DISPLAY_CONTROL_HISILE);
|
|
}
|
|
|
|
static const struct drm_encoder_helper_funcs hibmc_encoder_helper_funcs = {
|
|
.mode_set = hibmc_encoder_mode_set,
|
|
};
|
|
|
|
int hibmc_vdac_init(struct hibmc_drm_private *priv)
|
|
{
|
|
struct drm_device *dev = &priv->dev;
|
|
struct hibmc_connector *hibmc_connector = &priv->connector;
|
|
struct drm_encoder *encoder = &priv->encoder;
|
|
struct drm_crtc *crtc = &priv->crtc;
|
|
struct drm_connector *connector = &hibmc_connector->base;
|
|
int ret;
|
|
|
|
ret = hibmc_ddc_create(dev, hibmc_connector);
|
|
if (ret) {
|
|
drm_err(dev, "failed to create ddc: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
encoder->possible_crtcs = drm_crtc_mask(crtc);
|
|
ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC);
|
|
if (ret) {
|
|
drm_err(dev, "failed to init encoder: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
drm_encoder_helper_add(encoder, &hibmc_encoder_helper_funcs);
|
|
|
|
ret = drm_connector_init_with_ddc(dev, connector,
|
|
&hibmc_connector_funcs,
|
|
DRM_MODE_CONNECTOR_VGA,
|
|
&hibmc_connector->adapter);
|
|
if (ret) {
|
|
drm_err(dev, "failed to init connector: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
drm_connector_helper_add(connector, &hibmc_connector_helper_funcs);
|
|
|
|
drm_connector_attach_encoder(connector, encoder);
|
|
|
|
return 0;
|
|
}
|