mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
102d712ded
Let kconfig exit with error on duplicated Kconfig file inclusion.
Repeated inclusion of Kbuild files are considered bad-practise with
regard to maintenance; and Kconfig language is rich enough that there
should be no need for that.
If repeated inclusion of Kconfig files is detected, error out with
messages like:
Kconfig.inc1:4: error: repeated inclusion of Kconfig.inc3
Kconfig.inc2:3: note: location of first inclusion of Kconfig.inc3
While commit f094f8a1b2 ("kconfig: allow multiple inclusion of the
same file") introduced detection of recursive inclusions of Kconfig
files, it explicitly allowed repeated inclusions, unfortunately w/o
reasoning.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/all/CAHk-=wj03hLzK2D=+OYmjgcmGM+XYymp8GyaEs=C0=rXG2nb7w@mail.gmail.com/
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: https://patch.msgid.link/20260220-kconfig-error-out-on-duplicated-inclusion-v1-1-be78aa241a53@kernel.org
Signed-off-by: Nicolas Schier <nsc@kernel.org>
122 lines
2.5 KiB
C
122 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2002-2005 Roman Zippel <zippel@linux-m68k.org>
|
|
* Copyright (C) 2002-2005 Sam Ravnborg <sam@ravnborg.org>
|
|
*/
|
|
|
|
#include <stdarg.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <hash.h>
|
|
#include <hashtable.h>
|
|
#include <xalloc.h>
|
|
#include "lkc.h"
|
|
|
|
/* hash table of all parsed Kconfig files */
|
|
static HASHTABLE_DEFINE(file_hashtable, 1U << 11);
|
|
|
|
struct file {
|
|
struct hlist_node node;
|
|
struct {
|
|
const char *name;
|
|
int lineno;
|
|
} parent;
|
|
char name[];
|
|
};
|
|
|
|
static void die_duplicated_include(struct file *file,
|
|
const char *parent, int lineno)
|
|
{
|
|
fprintf(stderr,
|
|
"%s:%d: error: repeated inclusion of %s\n"
|
|
"%s:%d: note: location of first inclusion of %s\n",
|
|
parent, lineno, file->name,
|
|
file->parent.name, file->parent.lineno, file->name);
|
|
exit(1);
|
|
}
|
|
|
|
/* file already present in list? If not add it */
|
|
const char *file_lookup(const char *name,
|
|
const char *parent_name, int parent_lineno)
|
|
{
|
|
const char *parent = NULL;
|
|
struct file *file;
|
|
size_t len;
|
|
int hash = hash_str(name);
|
|
|
|
if (parent_name)
|
|
parent = file_lookup(parent_name, NULL, 0);
|
|
|
|
hash_for_each_possible(file_hashtable, file, node, hash)
|
|
if (!strcmp(name, file->name)) {
|
|
if (!parent_name)
|
|
return file->name;
|
|
die_duplicated_include(file, parent, parent_lineno);
|
|
}
|
|
|
|
len = strlen(name);
|
|
file = xmalloc(sizeof(*file) + len + 1);
|
|
memset(file, 0, sizeof(*file));
|
|
memcpy(file->name, name, len);
|
|
file->name[len] = '\0';
|
|
file->parent.name = parent;
|
|
file->parent.lineno = parent_lineno;
|
|
|
|
hash_add(file_hashtable, &file->node, hash);
|
|
|
|
str_printf(&autoconf_cmd, "\t%s \\\n", name);
|
|
|
|
return file->name;
|
|
}
|
|
|
|
/* Allocate initial growable string */
|
|
struct gstr str_new(void)
|
|
{
|
|
struct gstr gs;
|
|
gs.s = xmalloc(sizeof(char) * 64);
|
|
gs.len = 64;
|
|
gs.max_width = 0;
|
|
strcpy(gs.s, "\0");
|
|
return gs;
|
|
}
|
|
|
|
/* Free storage for growable string */
|
|
void str_free(struct gstr *gs)
|
|
{
|
|
free(gs->s);
|
|
gs->s = NULL;
|
|
gs->len = 0;
|
|
}
|
|
|
|
/* Append to growable string */
|
|
void str_append(struct gstr *gs, const char *s)
|
|
{
|
|
size_t l;
|
|
if (s) {
|
|
l = strlen(gs->s) + strlen(s) + 1;
|
|
if (l > gs->len) {
|
|
gs->s = xrealloc(gs->s, l);
|
|
gs->len = l;
|
|
}
|
|
strcat(gs->s, s);
|
|
}
|
|
}
|
|
|
|
/* Append printf formatted string to growable string */
|
|
void str_printf(struct gstr *gs, const char *fmt, ...)
|
|
{
|
|
va_list ap;
|
|
char s[10000]; /* big enough... */
|
|
va_start(ap, fmt);
|
|
vsnprintf(s, sizeof(s), fmt, ap);
|
|
str_append(gs, s);
|
|
va_end(ap);
|
|
}
|
|
|
|
/* Retrieve value of growable string */
|
|
char *str_get(const struct gstr *gs)
|
|
{
|
|
return gs->s;
|
|
}
|