mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 14:53:58 -04:00
5e30550558
In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > The conversion might include lossy conversion or a dangerous cast that > might go undetected due to the type being inferred. > > The lint is allowed by default as using `_` is less wordy than always > specifying the type. Always specifying the type is especially helpful in function call contexts where the inferred type may change at a distance. Specifying the type also allows Clippy to spot more cases of `useless_conversion`. The primary downside is the need to specify the type in trivial getters. There are 4 such functions: 3 have become slightly less ergonomic, 1 was revealed to be a `useless_conversion`. While this doesn't eliminate unchecked `as` conversions, it makes such conversions easier to scrutinize. It also has the slight benefit of removing a degree of freedom on which to bikeshed. Thus apply the changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_underscore [1] Reviewed-by: Benno Lossin <benno.lossin@proton.me> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Signed-off-by: Tamir Duberstein <tamird@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Danilo Krummrich <dakr@kernel.org> Link: https://lore.kernel.org/r/20250615-ptr-as-ptr-v12-4-f43b024581e8@gmail.com [ Changed `isize` to `c_long`. - Miguel ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
55 lines
1.4 KiB
Rust
55 lines
1.4 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
use kernel::{auxiliary, bindings, c_str, device::Core, pci, prelude::*};
|
|
|
|
use crate::gpu::Gpu;
|
|
|
|
#[pin_data]
|
|
pub(crate) struct NovaCore {
|
|
#[pin]
|
|
pub(crate) gpu: Gpu,
|
|
_reg: auxiliary::Registration,
|
|
}
|
|
|
|
const BAR0_SIZE: usize = 8;
|
|
pub(crate) type Bar0 = pci::Bar<BAR0_SIZE>;
|
|
|
|
kernel::pci_device_table!(
|
|
PCI_TABLE,
|
|
MODULE_PCI_TABLE,
|
|
<NovaCore as pci::Driver>::IdInfo,
|
|
[(
|
|
pci::DeviceId::from_id(bindings::PCI_VENDOR_ID_NVIDIA, bindings::PCI_ANY_ID as u32),
|
|
()
|
|
)]
|
|
);
|
|
|
|
impl pci::Driver for NovaCore {
|
|
type IdInfo = ();
|
|
const ID_TABLE: pci::IdTable<Self::IdInfo> = &PCI_TABLE;
|
|
|
|
fn probe(pdev: &pci::Device<Core>, _info: &Self::IdInfo) -> Result<Pin<KBox<Self>>> {
|
|
dev_dbg!(pdev.as_ref(), "Probe Nova Core GPU driver.\n");
|
|
|
|
pdev.enable_device_mem()?;
|
|
pdev.set_master();
|
|
|
|
let bar = pdev.iomap_region_sized::<BAR0_SIZE>(0, c_str!("nova-core/bar0"))?;
|
|
|
|
let this = KBox::pin_init(
|
|
try_pin_init!(Self {
|
|
gpu <- Gpu::new(pdev, bar)?,
|
|
_reg: auxiliary::Registration::new(
|
|
pdev.as_ref(),
|
|
c_str!("nova-drm"),
|
|
0, // TODO: Once it lands, use XArray; for now we don't use the ID.
|
|
crate::MODULE_NAME
|
|
)?,
|
|
}),
|
|
GFP_KERNEL,
|
|
)?;
|
|
|
|
Ok(this)
|
|
}
|
|
}
|