mirror of
https://github.com/torvalds/linux.git
synced 2026-04-21 08:13:56 -04:00
a2634a5ffc
When r8169 is built-in but LED support is a loadable module, the new
code to drive the LED causes a link failure:
ld: drivers/net/ethernet/realtek/r8169_leds.o: in function `rtl8168_init_leds':
r8169_leds.c:(.text+0x36c): undefined reference to `devm_led_classdev_register_ext'
LED support is an optional feature, so fix this issue by adding a Kconfig
symbol R8169_LEDS that is guaranteed to be false if r8169 is built-in
and LED core support is a module. As a positive side effect of this change
r8169_leds.o no longer is built under this configuration.
Fixes: 18764b883e ("r8169: add support for LED's on RTL8168/RTL8101")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@intel.com/
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
Tested-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/d055aeb5-fe5c-4ccf-987f-5af93a17537b@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
12 lines
325 B
Makefile
12 lines
325 B
Makefile
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Makefile for the Realtek network device drivers.
|
|
#
|
|
|
|
obj-$(CONFIG_8139CP) += 8139cp.o
|
|
obj-$(CONFIG_8139TOO) += 8139too.o
|
|
obj-$(CONFIG_ATP) += atp.o
|
|
r8169-y += r8169_main.o r8169_firmware.o r8169_phy_config.o
|
|
r8169-$(CONFIG_R8169_LEDS) += r8169_leds.o
|
|
obj-$(CONFIG_R8169) += r8169.o
|