mirror of
https://github.com/torvalds/linux.git
synced 2026-04-27 19:12:29 -04:00
ec956e2c6f
Commit 370f696e44 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
dma-names properties") documented dma-names property to handle Allwinner
D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the
reverse of what a different board expects:
rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected
A quick and incomplete check shows the inconsistency is present in many
other DTS files:
$ git grep -A10 snps,dw-apb-uart | grep dma-names | sort -u
arch/arm64/boot/dts/rockchip/px30.dtsi- dma-names = "tx", "rx";
arch/arm64/boot/dts/rockchip/rk3328.dtsi- dma-names = "tx", "rx";
arch/arm64/boot/dts/rockchip/rk3588s.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/rk3066a.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/rk3128.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/rk3288.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/rv1126.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/socfpga.dtsi- dma-names = "tx", "rx";
arch/arm/boot/dts/sun6i-a31.dtsi- dma-names = "rx", "tx";
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dma-names = "rx", "tx";
arch/arm/boot/dts/sun8i-v3s.dtsi- dma-names = "rx", "tx";
arch/arm/boot/dts/sunxi-h3-h5.dtsi- dma-names = "rx", "tx";
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dma-names = "rx", "tx";
The initial proposed solution was to allow a flexible dma-names order in
the binding, due to potential ABI breakage concerns after fixing the DTS
files. But luckily the Allwinner boards are not really affected, since
all of them are using a shared DMA channel for rx and tx:
$ git grep -A10 snps,dw-apb-uart | grep 'sun.*dmas' | sort -u
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 10>, <&dma 10>;
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 22>, <&dma 22>;
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 6>, <&dma 6>;
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 7>, <&dma 7>;
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 8>, <&dma 8>;
arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 9>, <&dma 9>;
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 10>, <&dma 10>;
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 6>, <&dma 6>;
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 7>, <&dma 7>;
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 8>, <&dma 8>;
arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 9>, <&dma 9>;
arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 6>, <&dma 6>;
arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 7>, <&dma 7>;
arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 8>, <&dma 8>;
arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 6>, <&dma 6>;
arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 7>, <&dma 7>;
arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 8>, <&dma 8>;
arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 9>, <&dma 9>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 14>, <&dma 14>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 15>, <&dma 15>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 16>, <&dma 16>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 17>, <&dma 17>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 18>, <&dma 18>;
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 19>, <&dma 19>;
Switch dma-names order to tx->rx as the first step in fixing the
inconsistency. The remaining DTS fixes will be handled by separate
patches.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230321215624.78383-2-cristian.ciocaltea@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
162 lines
3.9 KiB
YAML
162 lines
3.9 KiB
YAML
# SPDX-License-Identifier: GPL-2.0
|
|
%YAML 1.2
|
|
---
|
|
$id: http://devicetree.org/schemas/serial/snps-dw-apb-uart.yaml#
|
|
$schema: http://devicetree.org/meta-schemas/core.yaml#
|
|
|
|
title: Synopsys DesignWare ABP UART
|
|
|
|
maintainers:
|
|
- Rob Herring <robh@kernel.org>
|
|
|
|
allOf:
|
|
- $ref: serial.yaml#
|
|
|
|
properties:
|
|
compatible:
|
|
oneOf:
|
|
- items:
|
|
- enum:
|
|
- renesas,r9a06g032-uart
|
|
- renesas,r9a06g033-uart
|
|
- const: renesas,rzn1-uart
|
|
- items:
|
|
- enum:
|
|
- rockchip,px30-uart
|
|
- rockchip,rk1808-uart
|
|
- rockchip,rk3036-uart
|
|
- rockchip,rk3066-uart
|
|
- rockchip,rk3128-uart
|
|
- rockchip,rk3188-uart
|
|
- rockchip,rk3288-uart
|
|
- rockchip,rk3308-uart
|
|
- rockchip,rk3328-uart
|
|
- rockchip,rk3368-uart
|
|
- rockchip,rk3399-uart
|
|
- rockchip,rk3568-uart
|
|
- rockchip,rk3588-uart
|
|
- rockchip,rv1108-uart
|
|
- rockchip,rv1126-uart
|
|
- const: snps,dw-apb-uart
|
|
- items:
|
|
- enum:
|
|
- brcm,bcm11351-dw-apb-uart
|
|
- brcm,bcm21664-dw-apb-uart
|
|
- const: snps,dw-apb-uart
|
|
- items:
|
|
- enum:
|
|
- starfive,jh7100-hsuart
|
|
- starfive,jh7100-uart
|
|
- const: snps,dw-apb-uart
|
|
- const: snps,dw-apb-uart
|
|
|
|
reg:
|
|
maxItems: 1
|
|
|
|
interrupts:
|
|
maxItems: 1
|
|
|
|
clock-frequency: true
|
|
|
|
clocks:
|
|
minItems: 1
|
|
maxItems: 2
|
|
|
|
clock-names:
|
|
items:
|
|
- const: baudclk
|
|
- const: apb_pclk
|
|
|
|
dmas:
|
|
maxItems: 2
|
|
|
|
dma-names:
|
|
items:
|
|
- const: tx
|
|
- const: rx
|
|
|
|
snps,uart-16550-compatible:
|
|
description: reflects the value of UART_16550_COMPATIBLE configuration
|
|
parameter. Define this if your UART does not implement the busy functionality.
|
|
type: boolean
|
|
|
|
resets:
|
|
maxItems: 1
|
|
|
|
reg-shift: true
|
|
|
|
reg-io-width: true
|
|
|
|
dcd-override:
|
|
description: Override the DCD modem status signal. This signal will
|
|
always be reported as active instead of being obtained from the modem
|
|
status register. Define this if your serial port does not use this
|
|
pin.
|
|
type: boolean
|
|
|
|
dsr-override:
|
|
description: Override the DTS modem status signal. This signal will
|
|
always be reported as active instead of being obtained from the modem
|
|
status register. Define this if your serial port does not use this
|
|
pin.
|
|
type: boolean
|
|
|
|
cts-override:
|
|
description: Override the CTS modem status signal. This signal will
|
|
always be reported as active instead of being obtained from the modem
|
|
status register. Define this if your serial port does not use this
|
|
pin.
|
|
type: boolean
|
|
|
|
ri-override:
|
|
description: Override the RI modem status signal. This signal will always
|
|
be reported as inactive instead of being obtained from the modem status
|
|
register. Define this if your serial port does not use this pin.
|
|
type: boolean
|
|
|
|
required:
|
|
- compatible
|
|
- reg
|
|
- interrupts
|
|
|
|
unevaluatedProperties: false
|
|
|
|
examples:
|
|
- |
|
|
serial@80230000 {
|
|
compatible = "snps,dw-apb-uart";
|
|
reg = <0x80230000 0x100>;
|
|
clock-frequency = <3686400>;
|
|
interrupts = <10>;
|
|
reg-shift = <2>;
|
|
reg-io-width = <4>;
|
|
dcd-override;
|
|
dsr-override;
|
|
cts-override;
|
|
ri-override;
|
|
};
|
|
|
|
- |
|
|
// Example with one clock:
|
|
serial@80230000 {
|
|
compatible = "snps,dw-apb-uart";
|
|
reg = <0x80230000 0x100>;
|
|
clocks = <&baudclk>;
|
|
interrupts = <10>;
|
|
reg-shift = <2>;
|
|
reg-io-width = <4>;
|
|
};
|
|
|
|
- |
|
|
// Example with two clocks:
|
|
serial@80230000 {
|
|
compatible = "snps,dw-apb-uart";
|
|
reg = <0x80230000 0x100>;
|
|
clocks = <&baudclk>, <&apb_pclk>;
|
|
clock-names = "baudclk", "apb_pclk";
|
|
interrupts = <10>;
|
|
reg-shift = <2>;
|
|
reg-io-width = <4>;
|
|
};
|
|
...
|