mirror of
https://github.com/torvalds/linux.git
synced 2026-04-20 07:43:57 -04:00
78df43b958
CONFIG_RANDSTRUCT may reorder structure fields, which makes positional initializers unsafe. The i915 GT debugfs tables were using positional initializers for `struct intel_gt_debugfs_file`, and on configs where the layout differs (e.g., presence/absence of the `.eval` callback), this can lead to fields being initialized incorrectly and trigger randstruct warnings such as: ``` drivers/gpu/drm/i915/gt/intel_gt_debugfs.c:75:51: note: randstruct: casting between randomized structure pointer types (constructor) ``` Switch all the GT debugfs file arrays to designated initializers. This binds each value to the intended member regardless of structure reordering or optional members and removes the warning while preserving the intended initialization. Also drops the '&' from intel_eval_slpc_support so .eval receives the function pointer directly. No functional change, only initialization style is updated. Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> Link: https://lore.kernel.org/r/bae491e8098705a87304a7c94573b377e8c8fa37.1765897826.git.sebastian.brzezinka@intel.com
66 lines
1.8 KiB
C
66 lines
1.8 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2020 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/debugfs.h>
|
|
#include <linux/string_helpers.h>
|
|
|
|
#include <drm/drm_print.h>
|
|
|
|
#include "gt/intel_gt_debugfs.h"
|
|
#include "intel_guc_debugfs.h"
|
|
#include "intel_gsc_uc_debugfs.h"
|
|
#include "intel_huc_debugfs.h"
|
|
#include "intel_uc.h"
|
|
#include "intel_uc_debugfs.h"
|
|
|
|
static int uc_usage_show(struct seq_file *m, void *data)
|
|
{
|
|
struct intel_uc *uc = m->private;
|
|
struct drm_printer p = drm_seq_file_printer(m);
|
|
|
|
drm_printf(&p, "[guc] supported:%s wanted:%s used:%s\n",
|
|
str_yes_no(intel_uc_supports_guc(uc)),
|
|
str_yes_no(intel_uc_wants_guc(uc)),
|
|
str_yes_no(intel_uc_uses_guc(uc)));
|
|
drm_printf(&p, "[huc] supported:%s wanted:%s used:%s\n",
|
|
str_yes_no(intel_uc_supports_huc(uc)),
|
|
str_yes_no(intel_uc_wants_huc(uc)),
|
|
str_yes_no(intel_uc_uses_huc(uc)));
|
|
drm_printf(&p, "[submission] supported:%s wanted:%s used:%s\n",
|
|
str_yes_no(intel_uc_supports_guc_submission(uc)),
|
|
str_yes_no(intel_uc_wants_guc_submission(uc)),
|
|
str_yes_no(intel_uc_uses_guc_submission(uc)));
|
|
|
|
return 0;
|
|
}
|
|
DEFINE_INTEL_GT_DEBUGFS_ATTRIBUTE(uc_usage);
|
|
|
|
void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root)
|
|
{
|
|
static const struct intel_gt_debugfs_file files[] = {
|
|
{ .name = "usage", .fops = &uc_usage_fops },
|
|
};
|
|
struct dentry *root;
|
|
|
|
if (!gt_root)
|
|
return;
|
|
|
|
/* GuC and HuC go always in pair, no need to check both */
|
|
if (!intel_uc_supports_guc(uc))
|
|
return;
|
|
|
|
root = debugfs_create_dir("uc", gt_root);
|
|
if (IS_ERR(root))
|
|
return;
|
|
|
|
uc->guc.dbgfs_node = root;
|
|
|
|
intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
|
|
|
|
intel_gsc_uc_debugfs_register(&uc->gsc, root);
|
|
intel_guc_debugfs_register(&uc->guc, root);
|
|
intel_huc_debugfs_register(&uc->huc, root);
|
|
}
|