mirror of
https://github.com/torvalds/linux.git
synced 2026-04-19 07:13:56 -04:00
Remove test_generic_01.sh since block layer may reorder I/O, making the test prone to false positives. Apply the improvements to test_generic_02.sh instead, which supposes for covering ublk dispatch io order. Rework test_generic_02 to verify that ublk dispatch doesn't reorder I/O by comparing request start order with completion order using bpftrace. The bpftrace script now: - Tracks each request's start sequence number in a map keyed by sector - On completion, verifies the request's start order matches expected completion order - Reports any out-of-order completions detected The test script: - Wait bpftrace BEGIN code block is run - Pins fio to CPU 0 for deterministic behavior - Uses block_io_start and block_rq_complete tracepoints - Checks bpftrace output for reordering errors Reported-and-tested-by: Alexander Atanasov <alex@zazolabs.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
56 lines
1.2 KiB
Bash
Executable File
56 lines
1.2 KiB
Bash
Executable File
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
. "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
|
|
|
|
ERR_CODE=0
|
|
|
|
if ! _have_program bpftrace; then
|
|
exit "$UBLK_SKIP_CODE"
|
|
fi
|
|
|
|
if ! _have_program fio; then
|
|
exit "$UBLK_SKIP_CODE"
|
|
fi
|
|
|
|
_prep_test "null" "ublk dispatch won't reorder IO for MQ"
|
|
|
|
dev_id=$(_add_ublk_dev -t null -q 2)
|
|
_check_add_dev $TID $?
|
|
|
|
dev_t=$(_get_disk_dev_t "$dev_id")
|
|
bpftrace trace/seq_io.bt "$dev_t" "W" 1 > "$UBLK_TMP" 2>&1 &
|
|
btrace_pid=$!
|
|
|
|
# Wait for bpftrace probes to be attached (BEGIN block prints BPFTRACE_READY)
|
|
for _ in $(seq 100); do
|
|
grep -q "BPFTRACE_READY" "$UBLK_TMP" 2>/dev/null && break
|
|
sleep 0.1
|
|
done
|
|
|
|
if ! kill -0 "$btrace_pid" 2>/dev/null; then
|
|
_cleanup_test "null"
|
|
exit "$UBLK_SKIP_CODE"
|
|
fi
|
|
|
|
# run fio over this ublk disk (pinned to CPU 0)
|
|
taskset -c 0 fio --name=write_seq \
|
|
--filename=/dev/ublkb"${dev_id}" \
|
|
--ioengine=libaio --iodepth=16 \
|
|
--rw=write \
|
|
--size=512M \
|
|
--direct=1 \
|
|
--bs=4k > /dev/null 2>&1
|
|
ERR_CODE=$?
|
|
kill "$btrace_pid"
|
|
wait
|
|
|
|
# Check for out-of-order completions detected by bpftrace
|
|
if grep -q "^out_of_order:" "$UBLK_TMP"; then
|
|
echo "I/O reordering detected:"
|
|
grep "^out_of_order:" "$UBLK_TMP"
|
|
ERR_CODE=255
|
|
fi
|
|
_cleanup_test "null"
|
|
_show_result $TID $ERR_CODE
|