mirror of
https://github.com/torvalds/linux.git
synced 2026-05-01 13:02:35 -04:00
07e8f88568
This field is set to APIC_DELIVERY_MODE_FIXED in all cases, and is read
exactly once. Fold the constant in uv_program_mmr() and drop the field.
Searching for the origin of the stale HyperV comment reveals commit
a31e58e129 ("x86/apic: Switch all APICs to Fixed delivery mode") which
notes:
As a consequence of this change, the apic::irq_delivery_mode field is
now pointless, but this needs to be cleaned up in a separate patch.
6 years is long enough for this technical debt to have survived.
[ bp: Fold in
https://lore.kernel.org/r/20231121123034.1442059-1-andrew.cooper3@citrix.com
]
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
Link: https://lore.kernel.org/r/20231102-x86-apic-v1-1-bf049a2a0ed6@citrix.com
80 lines
2.4 KiB
C
80 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* NOOP APIC driver.
|
|
*
|
|
* Does almost nothing and should be substituted by a real apic driver via
|
|
* probe routine.
|
|
*
|
|
* Though in case if apic is disabled (for some reason) we try
|
|
* to not uglify the caller's code and allow to call (some) apic routines
|
|
* like self-ipi, etc...
|
|
*
|
|
* FIXME: Remove this gunk. The above argument which was intentionally left
|
|
* in place is silly to begin with because none of the callbacks except for
|
|
* APIC::read/write() have a WARN_ON_ONCE() in them. Sigh...
|
|
*/
|
|
#include <linux/cpumask.h>
|
|
#include <linux/thread_info.h>
|
|
|
|
#include <asm/apic.h>
|
|
|
|
#include "local.h"
|
|
|
|
static void noop_send_IPI(int cpu, int vector) { }
|
|
static void noop_send_IPI_mask(const struct cpumask *cpumask, int vector) { }
|
|
static void noop_send_IPI_mask_allbutself(const struct cpumask *cpumask, int vector) { }
|
|
static void noop_send_IPI_allbutself(int vector) { }
|
|
static void noop_send_IPI_all(int vector) { }
|
|
static void noop_send_IPI_self(int vector) { }
|
|
static void noop_apic_icr_write(u32 low, u32 id) { }
|
|
static int noop_wakeup_secondary_cpu(u32 apicid, unsigned long start_eip) { return -1; }
|
|
static u64 noop_apic_icr_read(void) { return 0; }
|
|
static u32 noop_phys_pkg_id(u32 cpuid_apic, int index_msb) { return 0; }
|
|
static u32 noop_get_apic_id(u32 apicid) { return 0; }
|
|
static void noop_apic_eoi(void) { }
|
|
|
|
static u32 noop_apic_read(u32 reg)
|
|
{
|
|
WARN_ON_ONCE(boot_cpu_has(X86_FEATURE_APIC) && !apic_is_disabled);
|
|
return 0;
|
|
}
|
|
|
|
static void noop_apic_write(u32 reg, u32 val)
|
|
{
|
|
WARN_ON_ONCE(boot_cpu_has(X86_FEATURE_APIC) && !apic_is_disabled);
|
|
}
|
|
|
|
struct apic apic_noop __ro_after_init = {
|
|
.name = "noop",
|
|
|
|
.dest_mode_logical = true,
|
|
|
|
.disable_esr = 0,
|
|
|
|
.check_apicid_used = default_check_apicid_used,
|
|
.ioapic_phys_id_map = default_ioapic_phys_id_map,
|
|
.cpu_present_to_apicid = default_cpu_present_to_apicid,
|
|
|
|
.phys_pkg_id = noop_phys_pkg_id,
|
|
|
|
.max_apic_id = 0xFE,
|
|
.get_apic_id = noop_get_apic_id,
|
|
|
|
.calc_dest_apicid = apic_flat_calc_apicid,
|
|
|
|
.send_IPI = noop_send_IPI,
|
|
.send_IPI_mask = noop_send_IPI_mask,
|
|
.send_IPI_mask_allbutself = noop_send_IPI_mask_allbutself,
|
|
.send_IPI_allbutself = noop_send_IPI_allbutself,
|
|
.send_IPI_all = noop_send_IPI_all,
|
|
.send_IPI_self = noop_send_IPI_self,
|
|
|
|
.wakeup_secondary_cpu = noop_wakeup_secondary_cpu,
|
|
|
|
.read = noop_apic_read,
|
|
.write = noop_apic_write,
|
|
.eoi = noop_apic_eoi,
|
|
.icr_read = noop_apic_icr_read,
|
|
.icr_write = noop_apic_icr_write,
|
|
};
|