mirror of
https://github.com/torvalds/linux.git
synced 2026-04-19 23:34:00 -04:00
981460d8ee
readq() is not available in 32bits and i915_gem_object_read_from_page()
is supposed to allow reading arbitrary sizes determined by the `size`
argument. Currently the only caller only passes a size == 8 so the
second problem is not that big. Migrate to calling
memcpy()/memcpy_fromio() to allow possible changes in the display side
and to fix the build on 32b architectures.
v2: Use memcpy/memcpy_fromio directly rather than using iosys-map with
the same size == 8 bytes restriction (Matt Roper)
Fixes: 44e694958b ("drm/xe/display: Implement display support")
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240119001612.2991381-4-lucas.demarchi@intel.com
(cherry picked from commit 406663f777)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
65 lines
1.2 KiB
C
65 lines
1.2 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2022 Intel Corporation
|
|
*/
|
|
|
|
#ifndef _I915_GEM_OBJECT_H_
|
|
#define _I915_GEM_OBJECT_H_
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include "xe_bo.h"
|
|
|
|
#define i915_gem_object_is_shmem(obj) ((obj)->flags & XE_BO_CREATE_SYSTEM_BIT)
|
|
|
|
static inline dma_addr_t i915_gem_object_get_dma_address(const struct xe_bo *bo, pgoff_t n)
|
|
{
|
|
/* Should never be called */
|
|
WARN_ON(1);
|
|
return n;
|
|
}
|
|
|
|
static inline bool i915_gem_object_is_tiled(const struct xe_bo *bo)
|
|
{
|
|
/* legacy tiling is unused */
|
|
return false;
|
|
}
|
|
|
|
static inline bool i915_gem_object_is_userptr(const struct xe_bo *bo)
|
|
{
|
|
/* legacy tiling is unused */
|
|
return false;
|
|
}
|
|
|
|
static inline int i915_gem_object_read_from_page(struct xe_bo *bo,
|
|
u32 ofs, u64 *ptr, u32 size)
|
|
{
|
|
struct ttm_bo_kmap_obj map;
|
|
void *src;
|
|
bool is_iomem;
|
|
int ret;
|
|
|
|
ret = xe_bo_lock(bo, true);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = ttm_bo_kmap(&bo->ttm, ofs >> PAGE_SHIFT, 1, &map);
|
|
if (ret)
|
|
goto out_unlock;
|
|
|
|
ofs &= ~PAGE_MASK;
|
|
src = ttm_kmap_obj_virtual(&map, &is_iomem);
|
|
src += ofs;
|
|
if (is_iomem)
|
|
memcpy_fromio(ptr, (void __iomem *)src, size);
|
|
else
|
|
memcpy(ptr, src, size);
|
|
|
|
ttm_bo_kunmap(&map);
|
|
out_unlock:
|
|
xe_bo_unlock(bo);
|
|
return ret;
|
|
}
|
|
|
|
#endif
|