mirror of
https://github.com/torvalds/linux.git
synced 2026-04-27 11:02:31 -04:00
904e582f0c
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231104211501.3676352-20-u.kleine-koenig@pengutronix.de Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
84 lines
2.0 KiB
C
84 lines
2.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Power off driver for ams AS3722 device.
|
|
*
|
|
* Copyright (c) 2013, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* Author: Laxman Dewangan <ldewangan@nvidia.com>
|
|
*/
|
|
|
|
#include <linux/mfd/as3722.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
|
|
struct as3722_poweroff {
|
|
struct device *dev;
|
|
struct as3722 *as3722;
|
|
};
|
|
|
|
static struct as3722_poweroff *as3722_pm_poweroff;
|
|
|
|
static void as3722_pm_power_off(void)
|
|
{
|
|
int ret;
|
|
|
|
if (!as3722_pm_poweroff) {
|
|
pr_err("AS3722 poweroff is not initialised\n");
|
|
return;
|
|
}
|
|
|
|
ret = as3722_update_bits(as3722_pm_poweroff->as3722,
|
|
AS3722_RESET_CONTROL_REG, AS3722_POWER_OFF, AS3722_POWER_OFF);
|
|
if (ret < 0)
|
|
dev_err(as3722_pm_poweroff->dev,
|
|
"RESET_CONTROL_REG update failed, %d\n", ret);
|
|
}
|
|
|
|
static int as3722_poweroff_probe(struct platform_device *pdev)
|
|
{
|
|
struct as3722_poweroff *as3722_poweroff;
|
|
struct device_node *np = pdev->dev.parent->of_node;
|
|
|
|
if (!np)
|
|
return -EINVAL;
|
|
|
|
if (!of_property_read_bool(np, "ams,system-power-controller"))
|
|
return 0;
|
|
|
|
as3722_poweroff = devm_kzalloc(&pdev->dev, sizeof(*as3722_poweroff),
|
|
GFP_KERNEL);
|
|
if (!as3722_poweroff)
|
|
return -ENOMEM;
|
|
|
|
as3722_poweroff->as3722 = dev_get_drvdata(pdev->dev.parent);
|
|
as3722_poweroff->dev = &pdev->dev;
|
|
as3722_pm_poweroff = as3722_poweroff;
|
|
if (!pm_power_off)
|
|
pm_power_off = as3722_pm_power_off;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void as3722_poweroff_remove(struct platform_device *pdev)
|
|
{
|
|
if (pm_power_off == as3722_pm_power_off)
|
|
pm_power_off = NULL;
|
|
as3722_pm_poweroff = NULL;
|
|
}
|
|
|
|
static struct platform_driver as3722_poweroff_driver = {
|
|
.driver = {
|
|
.name = "as3722-power-off",
|
|
},
|
|
.probe = as3722_poweroff_probe,
|
|
.remove_new = as3722_poweroff_remove,
|
|
};
|
|
|
|
module_platform_driver(as3722_poweroff_driver);
|
|
|
|
MODULE_DESCRIPTION("Power off driver for ams AS3722 PMIC Device");
|
|
MODULE_ALIAS("platform:as3722-power-off");
|
|
MODULE_AUTHOR("Laxman Dewangan <ldewangan@nvidia.com>");
|