mirror of
https://github.com/torvalds/linux.git
synced 2026-04-21 16:23:59 -04:00
When an attribute group is created with sysfs_create_group() or sysfs_create_files() the ->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show() callback to kobj_attr_show(). kobj_attr_show() uses container_of() to get the ->show() callback from the attribute it was passed, meaning the ->show() callback needs to be the same type as the ->show() callback in 'struct kobj_attribute'. However, cur_freq_show() has the type of the ->show() callback in 'struct device_attribute', which causes a CFI violation when opening the 'id' sysfs node under gtidle/freq/throttle. This happens to work because the layout of 'struct kobj_attribute' and 'struct device_attribute' are the same, so the container_of() cast happens to allow the ->show() callback to still work. Changed the type of cur_freq_show() and few more functions to match the ->show() callback in 'struct kobj_attributes' to resolve the CFI violation. CFI failure seen while accessing sysfs files under /sys/class/drm/card0/device/tile0/gt*/gtidle/* /sys/class/drm/card0/device/tile0/gt*/freq0/* /sys/class/drm/card0/device/tile0/gt*/freq0/throttle/* [ 2599.618075] RIP: 0010:__cfi_cur_freq_show+0xd/0x10 [xe] [ 2599.624452] Code: 44 c1 44 89 fa e8 03 95 39 f2 48 98 5b 41 5e 41 5f 5d c3 c9 [ 2599.646638] RSP: 0018:ffffbe438ead7d10 EFLAGS: 00010286 [ 2599.652823] RAX: ffff9f7d8b3845d8 RBX: ffff9f7dee8c95d8 RCX: 0000000000000000 [ 2599.661246] RDX: ffff9f7e6f439000 RSI: ffffffffc13ada30 RDI: ffff9f7d975d4b00 [ 2599.669669] RBP: ffffbe438ead7d18 R08: 0000000000001000 R09: ffff9f7e6f439000 [ 2599.678092] R10: 00000000e07304a6 R11: ffffffffc1241ca0 R12: ffffffffb4836ea0 [ 2599.688435] R13: ffff9f7e45fb1180 R14: ffff9f7d975d4b00 R15: ffff9f7e6f439000 [ 2599.696860] FS: 000076b02b66cfc0(0000) GS:ffff9f80ef400000(0000) knlGS:00000 [ 2599.706412] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 2599.713196] CR2: 00005f80d94641a9 CR3: 00000001e44ec006 CR4: 0000000100f72ef0 [ 2599.721618] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 2599.730041] DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400 [ 2599.738464] PKRU: 55555554 [ 2599.741655] Call Trace: [ 2599.744541] <TASK> [ 2599.747017] ? __die_body+0x69/0xb0 [ 2599.751151] ? die+0xa9/0xd0 [ 2599.754548] ? do_trap+0x89/0x160 [ 2599.758476] ? __cfi_cur_freq_show+0xd/0x10 [xe b37985c94829727668bd7c5b33c1] [ 2599.768315] ? handle_invalid_op+0x69/0x90 [ 2599.773167] ? __cfi_cur_freq_show+0xd/0x10 [xe b37985c94829727668bd7c5b33c1] [ 2599.783010] ? exc_invalid_op+0x36/0x60 [ 2599.787552] ? fred_hwexc+0x123/0x1a0 [ 2599.791873] ? fred_entry_from_kernel+0x7b/0xd0 [ 2599.797219] ? asm_fred_entrypoint_kernel+0x45/0x70 [ 2599.802976] ? act_freq_show+0x70/0x70 [xe b37985c94829727668bd7c5b33c1d9998] [ 2599.812301] ? __cfi_cur_freq_show+0xd/0x10 [xe b37985c94829727668bd7c5b33c1] [ 2599.822137] ? __kmalloc_node_noprof+0x1f3/0x420 [ 2599.827594] ? __kvmalloc_node_noprof+0xcb/0x180 [ 2599.833045] ? kobj_attr_show+0x22/0x40 [ 2599.837571] sysfs_kf_seq_show+0xa8/0x110 [ 2599.842302] kernfs_seq_show+0x38/0x50 Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://lore.kernel.org/r/20250422171852.85558-1-jeevaka.badrappan@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
404 lines
10 KiB
C
404 lines
10 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2023 Intel Corporation
|
|
*/
|
|
|
|
#include <drm/drm_managed.h>
|
|
|
|
#include "xe_force_wake.h"
|
|
#include "xe_device.h"
|
|
#include "xe_gt.h"
|
|
#include "xe_gt_idle.h"
|
|
#include "xe_gt_sysfs.h"
|
|
#include "xe_guc_pc.h"
|
|
#include "regs/xe_gt_regs.h"
|
|
#include "xe_macros.h"
|
|
#include "xe_mmio.h"
|
|
#include "xe_pm.h"
|
|
#include "xe_sriov.h"
|
|
|
|
/**
|
|
* DOC: Xe GT Idle
|
|
*
|
|
* Contains functions that init GT idle features like C6
|
|
*
|
|
* device/gt#/gtidle/name - name of the state
|
|
* device/gt#/gtidle/idle_residency_ms - Provides residency of the idle state in ms
|
|
* device/gt#/gtidle/idle_status - Provides current idle state
|
|
*/
|
|
|
|
static struct xe_gt_idle *dev_to_gtidle(struct device *dev)
|
|
{
|
|
struct kobject *kobj = &dev->kobj;
|
|
|
|
return &kobj_to_gt(kobj->parent)->gtidle;
|
|
}
|
|
|
|
static struct xe_gt *gtidle_to_gt(struct xe_gt_idle *gtidle)
|
|
{
|
|
return container_of(gtidle, struct xe_gt, gtidle);
|
|
}
|
|
|
|
static struct xe_guc_pc *gtidle_to_pc(struct xe_gt_idle *gtidle)
|
|
{
|
|
return >idle_to_gt(gtidle)->uc.guc.pc;
|
|
}
|
|
|
|
static struct xe_device *
|
|
pc_to_xe(struct xe_guc_pc *pc)
|
|
{
|
|
struct xe_guc *guc = container_of(pc, struct xe_guc, pc);
|
|
struct xe_gt *gt = container_of(guc, struct xe_gt, uc.guc);
|
|
|
|
return gt_to_xe(gt);
|
|
}
|
|
|
|
static const char *gt_idle_state_to_string(enum xe_gt_idle_state state)
|
|
{
|
|
switch (state) {
|
|
case GT_IDLE_C0:
|
|
return "gt-c0";
|
|
case GT_IDLE_C6:
|
|
return "gt-c6";
|
|
default:
|
|
return "unknown";
|
|
}
|
|
}
|
|
|
|
static u64 get_residency_ms(struct xe_gt_idle *gtidle, u64 cur_residency)
|
|
{
|
|
u64 delta, overflow_residency, prev_residency;
|
|
|
|
lockdep_assert_held(>idle->lock);
|
|
|
|
overflow_residency = BIT_ULL(32);
|
|
|
|
/*
|
|
* Counter wrap handling
|
|
* Store previous hw counter values for counter wrap-around handling
|
|
* Relying on sufficient frequency of queries otherwise counters can still wrap.
|
|
*/
|
|
prev_residency = gtidle->prev_residency;
|
|
gtidle->prev_residency = cur_residency;
|
|
|
|
/* delta */
|
|
if (cur_residency >= prev_residency)
|
|
delta = cur_residency - prev_residency;
|
|
else
|
|
delta = cur_residency + (overflow_residency - prev_residency);
|
|
|
|
/* Add delta to extended raw driver copy of idle residency */
|
|
cur_residency = gtidle->cur_residency + delta;
|
|
gtidle->cur_residency = cur_residency;
|
|
|
|
/* residency multiplier in ns, convert to ms */
|
|
cur_residency = mul_u64_u32_div(cur_residency, gtidle->residency_multiplier, 1e6);
|
|
|
|
return cur_residency;
|
|
}
|
|
|
|
void xe_gt_idle_enable_pg(struct xe_gt *gt)
|
|
{
|
|
struct xe_device *xe = gt_to_xe(gt);
|
|
struct xe_gt_idle *gtidle = >->gtidle;
|
|
struct xe_mmio *mmio = >->mmio;
|
|
u32 vcs_mask, vecs_mask;
|
|
unsigned int fw_ref;
|
|
int i, j;
|
|
|
|
if (IS_SRIOV_VF(xe))
|
|
return;
|
|
|
|
/* Disable CPG for PVC */
|
|
if (xe->info.platform == XE_PVC)
|
|
return;
|
|
|
|
xe_device_assert_mem_access(gt_to_xe(gt));
|
|
|
|
vcs_mask = xe_hw_engine_mask_per_class(gt, XE_ENGINE_CLASS_VIDEO_DECODE);
|
|
vecs_mask = xe_hw_engine_mask_per_class(gt, XE_ENGINE_CLASS_VIDEO_ENHANCE);
|
|
|
|
if (vcs_mask || vecs_mask)
|
|
gtidle->powergate_enable = MEDIA_POWERGATE_ENABLE;
|
|
|
|
if (!xe_gt_is_media_type(gt))
|
|
gtidle->powergate_enable |= RENDER_POWERGATE_ENABLE;
|
|
|
|
if (xe->info.platform != XE_DG1) {
|
|
for (i = XE_HW_ENGINE_VCS0, j = 0; i <= XE_HW_ENGINE_VCS7; ++i, ++j) {
|
|
if ((gt->info.engine_mask & BIT(i)))
|
|
gtidle->powergate_enable |= (VDN_HCP_POWERGATE_ENABLE(j) |
|
|
VDN_MFXVDENC_POWERGATE_ENABLE(j));
|
|
}
|
|
}
|
|
|
|
fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
|
|
if (xe->info.skip_guc_pc) {
|
|
/*
|
|
* GuC sets the hysteresis value when GuC PC is enabled
|
|
* else set it to 25 (25 * 1.28us)
|
|
*/
|
|
xe_mmio_write32(mmio, MEDIA_POWERGATE_IDLE_HYSTERESIS, 25);
|
|
xe_mmio_write32(mmio, RENDER_POWERGATE_IDLE_HYSTERESIS, 25);
|
|
}
|
|
|
|
xe_mmio_write32(mmio, POWERGATE_ENABLE, gtidle->powergate_enable);
|
|
xe_force_wake_put(gt_to_fw(gt), fw_ref);
|
|
}
|
|
|
|
void xe_gt_idle_disable_pg(struct xe_gt *gt)
|
|
{
|
|
struct xe_gt_idle *gtidle = >->gtidle;
|
|
unsigned int fw_ref;
|
|
|
|
if (IS_SRIOV_VF(gt_to_xe(gt)))
|
|
return;
|
|
|
|
xe_device_assert_mem_access(gt_to_xe(gt));
|
|
gtidle->powergate_enable = 0;
|
|
|
|
fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
|
|
xe_mmio_write32(>->mmio, POWERGATE_ENABLE, gtidle->powergate_enable);
|
|
xe_force_wake_put(gt_to_fw(gt), fw_ref);
|
|
}
|
|
|
|
/**
|
|
* xe_gt_idle_pg_print - Xe powergating info
|
|
* @gt: GT object
|
|
* @p: drm_printer.
|
|
*
|
|
* This function prints the powergating information
|
|
*
|
|
* Return: 0 on success, negative error code otherwise
|
|
*/
|
|
int xe_gt_idle_pg_print(struct xe_gt *gt, struct drm_printer *p)
|
|
{
|
|
struct xe_gt_idle *gtidle = >->gtidle;
|
|
struct xe_device *xe = gt_to_xe(gt);
|
|
enum xe_gt_idle_state state;
|
|
u32 pg_enabled, pg_status = 0;
|
|
u32 vcs_mask, vecs_mask;
|
|
unsigned int fw_ref;
|
|
int n;
|
|
/*
|
|
* Media Slices
|
|
*
|
|
* Slice 0: VCS0, VCS1, VECS0
|
|
* Slice 1: VCS2, VCS3, VECS1
|
|
* Slice 2: VCS4, VCS5, VECS2
|
|
* Slice 3: VCS6, VCS7, VECS3
|
|
*/
|
|
static const struct {
|
|
u64 engines;
|
|
u32 status_bit;
|
|
} media_slices[] = {
|
|
{(BIT(XE_HW_ENGINE_VCS0) | BIT(XE_HW_ENGINE_VCS1) |
|
|
BIT(XE_HW_ENGINE_VECS0)), MEDIA_SLICE0_AWAKE_STATUS},
|
|
|
|
{(BIT(XE_HW_ENGINE_VCS2) | BIT(XE_HW_ENGINE_VCS3) |
|
|
BIT(XE_HW_ENGINE_VECS1)), MEDIA_SLICE1_AWAKE_STATUS},
|
|
|
|
{(BIT(XE_HW_ENGINE_VCS4) | BIT(XE_HW_ENGINE_VCS5) |
|
|
BIT(XE_HW_ENGINE_VECS2)), MEDIA_SLICE2_AWAKE_STATUS},
|
|
|
|
{(BIT(XE_HW_ENGINE_VCS6) | BIT(XE_HW_ENGINE_VCS7) |
|
|
BIT(XE_HW_ENGINE_VECS3)), MEDIA_SLICE3_AWAKE_STATUS},
|
|
};
|
|
|
|
if (xe->info.platform == XE_PVC) {
|
|
drm_printf(p, "Power Gating not supported\n");
|
|
return 0;
|
|
}
|
|
|
|
state = gtidle->idle_status(gtidle_to_pc(gtidle));
|
|
pg_enabled = gtidle->powergate_enable;
|
|
|
|
/* Do not wake the GT to read powergating status */
|
|
if (state != GT_IDLE_C6) {
|
|
fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
|
|
if (!fw_ref)
|
|
return -ETIMEDOUT;
|
|
|
|
pg_enabled = xe_mmio_read32(>->mmio, POWERGATE_ENABLE);
|
|
pg_status = xe_mmio_read32(>->mmio, POWERGATE_DOMAIN_STATUS);
|
|
|
|
xe_force_wake_put(gt_to_fw(gt), fw_ref);
|
|
}
|
|
|
|
if (gt->info.engine_mask & XE_HW_ENGINE_RCS_MASK) {
|
|
drm_printf(p, "Render Power Gating Enabled: %s\n",
|
|
str_yes_no(pg_enabled & RENDER_POWERGATE_ENABLE));
|
|
|
|
drm_printf(p, "Render Power Gate Status: %s\n",
|
|
str_up_down(pg_status & RENDER_AWAKE_STATUS));
|
|
}
|
|
|
|
vcs_mask = xe_hw_engine_mask_per_class(gt, XE_ENGINE_CLASS_VIDEO_DECODE);
|
|
vecs_mask = xe_hw_engine_mask_per_class(gt, XE_ENGINE_CLASS_VIDEO_ENHANCE);
|
|
|
|
/* Print media CPG status only if media is present */
|
|
if (vcs_mask || vecs_mask) {
|
|
drm_printf(p, "Media Power Gating Enabled: %s\n",
|
|
str_yes_no(pg_enabled & MEDIA_POWERGATE_ENABLE));
|
|
|
|
for (n = 0; n < ARRAY_SIZE(media_slices); n++)
|
|
if (gt->info.engine_mask & media_slices[n].engines)
|
|
drm_printf(p, "Media Slice%d Power Gate Status: %s\n", n,
|
|
str_up_down(pg_status & media_slices[n].status_bit));
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t name_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buff)
|
|
{
|
|
struct device *dev = kobj_to_dev(kobj);
|
|
struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
|
|
struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
|
|
ssize_t ret;
|
|
|
|
xe_pm_runtime_get(pc_to_xe(pc));
|
|
ret = sysfs_emit(buff, "%s\n", gtidle->name);
|
|
xe_pm_runtime_put(pc_to_xe(pc));
|
|
|
|
return ret;
|
|
}
|
|
static struct kobj_attribute name_attr = __ATTR_RO(name);
|
|
|
|
static ssize_t idle_status_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buff)
|
|
{
|
|
struct device *dev = kobj_to_dev(kobj);
|
|
struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
|
|
struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
|
|
enum xe_gt_idle_state state;
|
|
|
|
xe_pm_runtime_get(pc_to_xe(pc));
|
|
state = gtidle->idle_status(pc);
|
|
xe_pm_runtime_put(pc_to_xe(pc));
|
|
|
|
return sysfs_emit(buff, "%s\n", gt_idle_state_to_string(state));
|
|
}
|
|
static struct kobj_attribute idle_status_attr = __ATTR_RO(idle_status);
|
|
|
|
u64 xe_gt_idle_residency_msec(struct xe_gt_idle *gtidle)
|
|
{
|
|
struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
|
|
u64 residency;
|
|
unsigned long flags;
|
|
|
|
raw_spin_lock_irqsave(>idle->lock, flags);
|
|
residency = get_residency_ms(gtidle, gtidle->idle_residency(pc));
|
|
raw_spin_unlock_irqrestore(>idle->lock, flags);
|
|
|
|
return residency;
|
|
}
|
|
|
|
|
|
static ssize_t idle_residency_ms_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buff)
|
|
{
|
|
struct device *dev = kobj_to_dev(kobj);
|
|
struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
|
|
struct xe_guc_pc *pc = gtidle_to_pc(gtidle);
|
|
u64 residency;
|
|
|
|
xe_pm_runtime_get(pc_to_xe(pc));
|
|
residency = xe_gt_idle_residency_msec(gtidle);
|
|
xe_pm_runtime_put(pc_to_xe(pc));
|
|
|
|
return sysfs_emit(buff, "%llu\n", residency);
|
|
}
|
|
static struct kobj_attribute idle_residency_attr = __ATTR_RO(idle_residency_ms);
|
|
|
|
static const struct attribute *gt_idle_attrs[] = {
|
|
&name_attr.attr,
|
|
&idle_status_attr.attr,
|
|
&idle_residency_attr.attr,
|
|
NULL,
|
|
};
|
|
|
|
static void gt_idle_fini(void *arg)
|
|
{
|
|
struct kobject *kobj = arg;
|
|
struct xe_gt *gt = kobj_to_gt(kobj->parent);
|
|
unsigned int fw_ref;
|
|
|
|
xe_gt_idle_disable_pg(gt);
|
|
|
|
if (gt_to_xe(gt)->info.skip_guc_pc) {
|
|
fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
|
|
xe_gt_idle_disable_c6(gt);
|
|
xe_force_wake_put(gt_to_fw(gt), fw_ref);
|
|
}
|
|
|
|
sysfs_remove_files(kobj, gt_idle_attrs);
|
|
kobject_put(kobj);
|
|
}
|
|
|
|
int xe_gt_idle_init(struct xe_gt_idle *gtidle)
|
|
{
|
|
struct xe_gt *gt = gtidle_to_gt(gtidle);
|
|
struct xe_device *xe = gt_to_xe(gt);
|
|
struct kobject *kobj;
|
|
int err;
|
|
|
|
if (IS_SRIOV_VF(xe))
|
|
return 0;
|
|
|
|
kobj = kobject_create_and_add("gtidle", gt->sysfs);
|
|
if (!kobj)
|
|
return -ENOMEM;
|
|
|
|
raw_spin_lock_init(>idle->lock);
|
|
|
|
if (xe_gt_is_media_type(gt)) {
|
|
snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-mc", gt->info.id);
|
|
gtidle->idle_residency = xe_guc_pc_mc6_residency;
|
|
} else {
|
|
snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-rc", gt->info.id);
|
|
gtidle->idle_residency = xe_guc_pc_rc6_residency;
|
|
}
|
|
|
|
/* Multiplier for Residency counter in units of 1.28us */
|
|
gtidle->residency_multiplier = 1280;
|
|
gtidle->idle_status = xe_guc_pc_c_status;
|
|
|
|
err = sysfs_create_files(kobj, gt_idle_attrs);
|
|
if (err) {
|
|
kobject_put(kobj);
|
|
return err;
|
|
}
|
|
|
|
xe_gt_idle_enable_pg(gt);
|
|
|
|
return devm_add_action_or_reset(xe->drm.dev, gt_idle_fini, kobj);
|
|
}
|
|
|
|
void xe_gt_idle_enable_c6(struct xe_gt *gt)
|
|
{
|
|
xe_device_assert_mem_access(gt_to_xe(gt));
|
|
xe_force_wake_assert_held(gt_to_fw(gt), XE_FW_GT);
|
|
|
|
if (IS_SRIOV_VF(gt_to_xe(gt)))
|
|
return;
|
|
|
|
/* Units of 1280 ns for a total of 5s */
|
|
xe_mmio_write32(>->mmio, RC_IDLE_HYSTERSIS, 0x3B9ACA);
|
|
/* Enable RC6 */
|
|
xe_mmio_write32(>->mmio, RC_CONTROL,
|
|
RC_CTL_HW_ENABLE | RC_CTL_TO_MODE | RC_CTL_RC6_ENABLE);
|
|
}
|
|
|
|
void xe_gt_idle_disable_c6(struct xe_gt *gt)
|
|
{
|
|
xe_device_assert_mem_access(gt_to_xe(gt));
|
|
xe_force_wake_assert_held(gt_to_fw(gt), XE_FW_GT);
|
|
|
|
if (IS_SRIOV_VF(gt_to_xe(gt)))
|
|
return;
|
|
|
|
xe_mmio_write32(>->mmio, RC_CONTROL, 0);
|
|
xe_mmio_write32(>->mmio, RC_STATE, 0);
|
|
}
|