mirror of
https://github.com/torvalds/linux.git
synced 2026-04-26 18:42:25 -04:00
de124b61e1
dss_of_port_get_parent_device() leaks an OF node reference when i >= 2
and struct device_node *np is present. Since of_get_next_parent()
obtains a reference of the returned OF node, call of_node_put() before
returning NULL.
This was found by an experimental verifier that I am developing, and no
runtime test was able to be performed due to that lack of actual
devices.
Fixes: f76ee892a9 ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Helge Deller <deller@gmx.de>
78 lines
1.4 KiB
C
78 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2013 Texas Instruments
|
|
* Author: Tomi Valkeinen <tomi.valkeinen@ti.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/err.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_graph.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <video/omapfb_dss.h>
|
|
|
|
#include "dss.h"
|
|
|
|
struct device_node *dss_of_port_get_parent_device(struct device_node *port)
|
|
{
|
|
struct device_node *np;
|
|
int i;
|
|
|
|
if (!port)
|
|
return NULL;
|
|
|
|
np = of_get_parent(port);
|
|
|
|
for (i = 0; i < 2 && np; ++i) {
|
|
struct property *prop;
|
|
|
|
prop = of_find_property(np, "compatible", NULL);
|
|
|
|
if (prop)
|
|
return np;
|
|
|
|
np = of_get_next_parent(np);
|
|
}
|
|
|
|
of_node_put(np);
|
|
return NULL;
|
|
}
|
|
|
|
u32 dss_of_port_get_port_number(struct device_node *port)
|
|
{
|
|
int r;
|
|
u32 reg;
|
|
|
|
r = of_property_read_u32(port, "reg", ®);
|
|
if (r)
|
|
reg = 0;
|
|
|
|
return reg;
|
|
}
|
|
|
|
struct omap_dss_device *
|
|
omapdss_of_find_source_for_first_ep(struct device_node *node)
|
|
{
|
|
struct device_node *ep;
|
|
struct device_node *src_port;
|
|
struct omap_dss_device *src;
|
|
|
|
ep = of_graph_get_endpoint_by_regs(node, 0, -1);
|
|
if (!ep)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
src_port = of_graph_get_remote_port(ep);
|
|
of_node_put(ep);
|
|
if (!src_port)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
src = omap_dss_find_output_by_port_node(src_port);
|
|
|
|
of_node_put(src_port);
|
|
|
|
return src ? src : ERR_PTR(-EPROBE_DEFER);
|
|
}
|
|
EXPORT_SYMBOL_GPL(omapdss_of_find_source_for_first_ep);
|