mirror of
https://github.com/torvalds/linux.git
synced 2026-04-22 00:33:58 -04:00
965930962a
The current attempted split between xe/i915 vs. display for intel_frontbuffer is a mess: - the i915 rcu leaks through the interface to the display side - the obj->frontbuffer write-side is now protected by a display specific spinlock even though the actual obj->framebuffer pointer lives in a i915 specific structure - the kref is getting poked directly from both sides - i915_active is still on the display side Clean up the mess by moving everything about the frontbuffer lifetime management to the i915/xe side: - the rcu usage is now completely contained in i915 - frontbuffer_lock is moved into i915 - kref is on the i915/xe side (xe needs the refcount as well due to intel_frontbuffer_queue_flush()->intel_frontbuffer_ref()) - the bo (and its refcounting) is no longer on the display side - i915_active is contained in i915 I was pondering whether we could do this in some kind of smaller steps, and perhaps we could, but it would probably have to start with a bunch of reverts (which for sure won't go cleanly anymore). So not convinced it's worth the hassle. Acked-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patch.msgid.link/20251016185408.22735-10-ville.syrjala@linux.intel.com
30 lines
1.0 KiB
C
30 lines
1.0 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/* Copyright © 2024 Intel Corporation */
|
|
|
|
#ifndef __INTEL_BO__
|
|
#define __INTEL_BO__
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct drm_gem_object;
|
|
struct drm_scanout_buffer;
|
|
struct intel_framebuffer;
|
|
struct seq_file;
|
|
struct vm_area_struct;
|
|
|
|
bool intel_bo_is_tiled(struct drm_gem_object *obj);
|
|
bool intel_bo_is_userptr(struct drm_gem_object *obj);
|
|
bool intel_bo_is_shmem(struct drm_gem_object *obj);
|
|
bool intel_bo_is_protected(struct drm_gem_object *obj);
|
|
int intel_bo_fb_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
|
|
int intel_bo_read_from_page(struct drm_gem_object *obj, u64 offset, void *dst, int size);
|
|
|
|
struct intel_frontbuffer *intel_bo_frontbuffer_get(struct drm_gem_object *obj);
|
|
void intel_bo_frontbuffer_ref(struct intel_frontbuffer *front);
|
|
void intel_bo_frontbuffer_put(struct intel_frontbuffer *front);
|
|
void intel_bo_frontbuffer_flush_for_display(struct intel_frontbuffer *front);
|
|
|
|
void intel_bo_describe(struct seq_file *m, struct drm_gem_object *obj);
|
|
|
|
#endif /* __INTEL_BO__ */
|