mirror of
https://github.com/torvalds/linux.git
synced 2026-04-19 23:34:00 -04:00
adefb2ccea
Don't mix dma fence lock with the active_job lock. Use fence_lock to
protect the dma fence used by drm scheduler when signalling a job
completion and queue_lock to protect concurrent access to active bin job
in OOM and stats collection for a given file priv. The issue was
uncovered when PREEMPT_RT on with a system freeze when opening multiple
Chromium tabs on Raspberry Pi 5.
Link: https://github.com/raspberrypi/linux/issues/7035
Fixes: fa6a20c874 ("drm/v3d: Address race-condition between per-fd GPU stats and fd release")
Signed-off-by: Melissa Wen <mwen@igalia.com>
Acked-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://lore.kernel.org/r/20250916172022.2779837-1-mwen@igalia.com
51 lines
1.1 KiB
C
51 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/* Copyright (C) 2017-2018 Broadcom */
|
|
|
|
#include "v3d_drv.h"
|
|
|
|
struct dma_fence *v3d_fence_create(struct v3d_dev *v3d, enum v3d_queue q)
|
|
{
|
|
struct v3d_queue_state *queue = &v3d->queue[q];
|
|
struct v3d_fence *fence;
|
|
|
|
fence = kzalloc(sizeof(*fence), GFP_KERNEL);
|
|
if (!fence)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
fence->dev = &v3d->drm;
|
|
fence->queue = q;
|
|
fence->seqno = ++queue->emit_seqno;
|
|
dma_fence_init(&fence->base, &v3d_fence_ops, &queue->fence_lock,
|
|
queue->fence_context, fence->seqno);
|
|
|
|
return &fence->base;
|
|
}
|
|
|
|
static const char *v3d_fence_get_driver_name(struct dma_fence *fence)
|
|
{
|
|
return "v3d";
|
|
}
|
|
|
|
static const char *v3d_fence_get_timeline_name(struct dma_fence *fence)
|
|
{
|
|
struct v3d_fence *f = to_v3d_fence(fence);
|
|
|
|
switch (f->queue) {
|
|
case V3D_BIN:
|
|
return "v3d-bin";
|
|
case V3D_RENDER:
|
|
return "v3d-render";
|
|
case V3D_TFU:
|
|
return "v3d-tfu";
|
|
case V3D_CSD:
|
|
return "v3d-csd";
|
|
default:
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
const struct dma_fence_ops v3d_fence_ops = {
|
|
.get_driver_name = v3d_fence_get_driver_name,
|
|
.get_timeline_name = v3d_fence_get_timeline_name,
|
|
};
|