Files
linux/include/linux
David Lechner ca52aa4c60 spi: add defer_optimize_message controller flag
Adding spi_optimize_message() broke the spi-mux driver because it
calls spi_async() from it's transfer_one_message() callback. This
resulted in passing an incorrectly optimized message to the controller.
For example, if the underlying controller has an optimize_message()
callback, this would have not been called and can cause a crash when
the underlying controller driver tries to transfer the message.

Also, since the spi-mux driver swaps out the controller pointer by
replacing msg->spi, __spi_unoptimize_message() was being called with a
different controller than the one used in __spi_optimize_message(). This
could cause a crash when attempting to free the message resources when
__spi_unoptimize_message() is called in spi_finalize_current_message()
since it is being called with a controller that did not allocate the
resources.

This is fixed by adding a defer_optimize_message flag for controllers.
This flag causes all of the spi_[maybe_][un]optimize_message() calls to
be a no-op (other than attaching a pointer to the spi device to the
message).

This allows the spi-mux driver to pass an unmodified message to
spi_async() in spi_mux_transfer_one_message() after the spi device has
been swapped out. This causes __spi_optimize_message() and
__spi_unoptimize_message() to be called only once per message and with
the correct/same controller in each case.

Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Closes: https://lore.kernel.org/linux-spi/Zn6HMrYG2b7epUxT@pengutronix.de/
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Closes: https://lore.kernel.org/linux-spi/20240628-awesome-discerning-bear-1621f9-mkl@pengutronix.de/
Fixes: 7b1d87af14 ("spi: add spi_optimize_message() APIs")
Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20240708-spi-mux-fix-v1-2-6c8845193128@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-07-09 17:42:32 +01:00
..
2024-04-24 11:06:26 -07:00
2024-04-25 20:55:49 -07:00
2024-05-02 20:35:57 +02:00
2024-04-17 08:44:03 -06:00
2024-04-29 16:28:07 -07:00
2024-05-08 17:29:22 -04:00
2024-04-23 09:03:37 +09:00
2024-05-05 17:53:55 -07:00
2024-05-11 00:41:15 +00:00
2024-04-15 16:03:24 -04:00
2024-05-09 13:02:39 +02:00
2024-05-19 14:36:17 -07:00
2024-05-22 16:12:48 -07:00
2024-05-19 14:40:44 -07:00
2024-04-23 13:16:03 +02:00
2024-06-21 13:33:17 +02:00
2024-06-05 19:19:26 -07:00
2024-05-03 10:44:42 +01:00
2024-06-15 10:43:05 -07:00
2024-04-15 14:31:48 +02:00
2024-05-05 17:53:49 -07:00
2024-05-05 17:53:50 -07:00
2024-04-15 19:43:48 +02:00
2024-04-02 18:03:32 -07:00
2024-04-03 09:59:38 +01:00
2024-05-02 16:28:15 +02:00
2024-04-09 10:53:44 +02:00
2024-05-04 18:57:21 +02:00
2024-05-23 19:40:26 -07:00
2024-04-08 11:49:02 +01:00
2024-05-06 12:05:00 +02:00
2024-04-07 02:42:36 -04:00
2024-04-25 20:55:48 -07:00