Files
linux/drivers/gpu/drm/xe
Mirsad Todorovac cb57c75098 drm/xe: fix the ERR_PTR() returned on failure to allocate tiny pt
Running coccinelle spatch gave the following warning:

./drivers/gpu/drm/xe/tests/xe_migrate.c:226:5-11: inconsistent IS_ERR
and PTR_ERR on line 228.

The code reports PTR_ERR(pt) when IS_ERR(tiny) is checked:

→ 211  pt = xe_bo_create_pin_map(xe, tile, m->q->vm, XE_PAGE_SIZE,
  212                            ttm_bo_type_kernel,
  213                            XE_BO_FLAG_VRAM_IF_DGFX(tile) |
  214                            XE_BO_FLAG_PINNED);
  215  if (IS_ERR(pt)) {
  216          KUNIT_FAIL(test, "Failed to allocate fake pt: %li\n",
  217                     PTR_ERR(pt));
  218          goto free_big;
  219  }
  220
  221  tiny = xe_bo_create_pin_map(xe, tile, m->q->vm,
→ 222                              2 * SZ_4K,
  223                              ttm_bo_type_kernel,
  224                              XE_BO_FLAG_VRAM_IF_DGFX(tile) |
  225                              XE_BO_FLAG_PINNED);
→ 226  if (IS_ERR(tiny)) {
→ 227          KUNIT_FAIL(test, "Failed to allocate fake pt: %li\n",
→ 228                     PTR_ERR(pt));
  229          goto free_pt;
  230  }

Now, the IS_ERR(tiny) and the corresponding PTR_ERR(pt) do not match.

Returning PTR_ERR(tiny), as the last failed function call, seems logical.

Fixes: dd08ebf6c3 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241121212057.1526634-2-mtodorovac69@gmail.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2024-12-09 11:47:17 -05:00
..
2024-06-18 12:40:38 -07:00
2024-12-03 15:02:55 -05:00
2024-12-03 15:02:55 -05:00
2024-05-09 21:28:25 +02:00
2024-12-06 09:40:00 -05:00
2024-12-03 15:02:55 -05:00
2024-11-15 15:59:51 -08:00
2024-11-15 15:59:51 -08:00
2024-11-15 15:59:51 -08:00
2024-10-04 11:46:30 +02:00
2024-05-13 21:36:50 +02:00
2024-11-15 15:59:51 -08:00
2024-05-22 12:03:55 +02:00
2024-11-15 15:59:51 -08:00
2024-06-26 18:25:22 -04:00
2024-12-05 07:37:53 -08:00
2024-09-19 10:15:40 +02:00
2024-05-07 12:03:49 +02:00
2024-11-15 15:59:50 -08:00
2024-05-13 21:36:52 +02:00
2024-06-18 12:03:29 -07:00
2024-09-16 12:58:26 -07:00
2024-12-06 09:40:00 -05:00
2024-11-26 09:36:28 +00:00
2024-07-18 10:25:33 -04:00
2024-07-18 10:25:33 -04:00
2024-12-02 15:03:58 -05:00
2024-12-09 09:59:47 -05:00
2024-12-03 15:02:55 -05:00
2024-11-27 05:36:55 -05:00
2024-07-24 09:05:37 -07:00