Bart Van Assche c846868070 pktcdvd: Fix a recently introduced NULL pointer dereference ...

commit 882d4171a8 upstream.

Call bdev_get_queue(bdev) after bdev->bd_disk has been initialized
instead of just before that pointer has been initialized. This patch
avoids that the following command

pktsetup 1 /dev/sr0

triggers the following kernel crash:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000548
IP: pkt_setup_dev+0x2db/0x670 [pktcdvd]
CPU: 2 PID: 724 Comm: pktsetup Not tainted 4.15.0-rc4-dbg+ #1
Call Trace:
 pkt_ctl_ioctl+0xce/0x1c0 [pktcdvd]
 do_vfs_ioctl+0x8e/0x670
 SyS_ioctl+0x3c/0x70
 entry_SYSCALL_64_fastpath+0x23/0x9a

Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: commit ca18d6f769 ("block: Make most scsi_req_init() calls implicit")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-02-16 20:23:08 +01:00

..

aoe

block: don't set bounce limit in blk_init_queue

2017-06-27 12:13:45 -06:00

drbd

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mtip32xx

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

paride

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rsxx

block: pass in queue to inflight accounting

2017-08-09 13:09:16 -06:00

xen-blkback

Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block

2017-09-07 11:59:42 -07:00

zram

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

amiflop.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

ataflop.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

brd.c

brd: fix overflow in __brd_direct_access

2017-09-25 08:56:05 -06:00

cryptoloop.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

DAC960.c

block: DAC960: shut up format-overflow warning

2017-07-29 09:00:03 -06:00

DAC960.h

Fix DAC960 driver on machines which don't support 64-bit DMA

2007-09-11 17:21:19 -07:00

floppy.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

Kconfig

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

loop.c

loop: fix concurrent lo_open/lo_release

2018-02-03 17:38:47 +01:00

loop.h

loop: remove union of use_aio and ref in struct loop_cmd

2017-09-25 08:56:05 -06:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nbd.c

nbd: don't start req until after the dead connection logic

2017-11-30 08:40:41 +00:00

null_blk.c

null_blk: fix dev->badblocks leak

2018-02-03 17:39:00 +01:00

pktcdvd.c

pktcdvd: Fix a recently introduced NULL pointer dereference

2018-02-16 20:23:08 +01:00

ps3disk.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

ps3vram.c

block/ps3vram: Check return of ps3vram_cache_init

2017-08-17 23:03:44 +10:00

rbd_types.h

rbd: RBD_V{1,2}_DATA_FORMAT macros

2017-02-20 12:16:15 +01:00

rbd.c

rbd: set max_segments to USHRT_MAX

2018-01-17 09:45:23 +01:00

skd_main.c

skd: Use kmem_cache_free

2017-10-09 08:31:27 -06:00

skd_s1120.h

skd: Use __packed only when needed

2017-08-18 08:45:29 -06:00

smart1,2.h

fix typos 'comamnd' -> 'command' in comments

2011-02-02 11:31:21 +01:00

sunvdc.c

sunvdc: prevent sunvdc panic when mpgroup disk added to guest domain

2017-08-09 22:22:32 -07:00

swim3.c

block: don't set bounce limit in blk_init_queue

2017-06-27 12:13:45 -06:00

swim_asm.S

m68k: mac - Add SWIM floppy support

2009-03-26 21:15:27 +01:00

swim.c

block: don't set bounce limit in blk_init_queue

2017-06-27 12:13:45 -06:00

sx8.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

umem.c

blk: remove bio_set arg from blk_queue_split()

2017-06-18 12:40:59 -06:00

umem.h

drivers/block/umem: trim trailing whitespace

2007-10-10 09:25:59 +02:00

virtio_blk.c

virtio_blk: Fix an SG_IO regression

2017-10-27 08:23:21 -06:00

xen-blkfront.c

Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block

2017-09-07 11:59:42 -07:00

xsysace.c

block: don't set bounce limit in blk_init_queue

2017-06-27 12:13:45 -06:00

z2ram.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00