Files
linux/drivers/gpu/drm/amd/amdgpu
Kees Cook e5f7e4e0a4 drm/amdgpu/atom: Work around vbios NULL offset false positive
GCC really does not want to consider NULL (or near-NULL) addresses as
valid, so calculations based off of NULL end up getting range-tracked into
being an offset wthin a 0 byte array. It gets especially mad about this:

                if (vbios_str == NULL)
                        vbios_str += sizeof(BIOS_ATOM_PREFIX) - 1;
	...
        if (vbios_str != NULL && *vbios_str == 0)
                vbios_str++;

It sees this as being "sizeof(BIOS_ATOM_PREFIX) - 1" byte offset from
NULL, when building with -Warray-bounds (and the coming
-fdiagnostic-details flag):

In function 'atom_get_vbios_pn',
    inlined from 'amdgpu_atom_parse' at drivers/gpu/drm/amd/amdgpu/atom.c:1553:2:
drivers/gpu/drm/amd/amdgpu/atom.c:1447:34: error: array subscript 0 is outside array bounds of 'unsigned char[0]' [-Werror=array-bounds=]
 1447 |         if (vbios_str != NULL && *vbios_str == 0)
      |                                  ^~~~~~~~~~
  'amdgpu_atom_parse': events 1-2
 1444 |                 if (vbios_str == NULL)
      |                    ^
      |                    |
      |                    (1) when the condition is evaluated to true
......
 1447 |         if (vbios_str != NULL && *vbios_str == 0)
      |                                  ~~~~~~~~~~
      |                                  |
      |                                  (2) out of array bounds here
In function 'amdgpu_atom_parse':
cc1: note: source object is likely at address zero

As there isn't a sane way to convince it otherwise, hide vbios_str from
GCC's optimizer to avoid the warning so we can get closer to enabling
-Warray-bounds globally.

Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2025-04-30 18:04:12 -04:00
..
2025-04-07 15:18:34 -04:00
2025-04-08 16:48:14 -04:00
2024-07-24 17:30:23 -04:00
2025-03-26 17:44:34 -04:00
2024-11-03 01:28:06 -05:00
2025-02-25 11:45:12 -05:00
2025-02-12 21:05:50 -05:00
2024-01-15 18:35:37 -05:00
2024-01-15 18:35:37 -05:00
2024-01-15 18:35:37 -05:00
2025-04-08 16:48:13 -04:00
2025-04-08 16:48:13 -04:00
2024-07-24 17:30:23 -04:00
2024-07-24 17:30:23 -04:00
2025-04-07 15:18:34 -04:00
2025-04-07 15:18:34 -04:00
2025-04-07 15:18:34 -04:00
2025-04-21 10:55:51 -04:00
2023-08-07 16:35:38 -04:00
2023-03-15 18:45:26 -04:00
2023-03-15 18:45:26 -04:00
2023-08-30 15:00:27 -04:00
2025-03-13 23:08:51 -04:00
2025-04-08 16:48:14 -04:00
2025-04-08 16:48:14 -04:00
2025-03-26 17:44:34 -04:00
2025-03-05 10:37:13 -05:00
2025-03-05 10:37:13 -05:00
2023-08-31 16:34:05 -04:00