mirror of
https://github.com/torvalds/linux.git
synced 2026-05-05 15:02:40 -04:00
d8300e6e07
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.
Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:
req->rate = divider_round_rate(...)
This is invalid in the case when an error occurs since it can set the
rate to a negative value.
Fixes: b6f90511c1 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260108-clk-divider-round-rate-v1-16-535a3ed73bf3@redhat.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
83 lines
2.2 KiB
C
83 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2014, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/export.h>
|
|
|
|
#include "clk-regmap-divider.h"
|
|
|
|
static inline struct clk_regmap_div *to_clk_regmap_div(struct clk_hw *hw)
|
|
{
|
|
return container_of(to_clk_regmap(hw), struct clk_regmap_div, clkr);
|
|
}
|
|
|
|
static int div_ro_determine_rate(struct clk_hw *hw,
|
|
struct clk_rate_request *req)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
struct clk_regmap *clkr = ÷r->clkr;
|
|
u32 val;
|
|
|
|
regmap_read(clkr->regmap, divider->reg, &val);
|
|
val >>= divider->shift;
|
|
val &= BIT(divider->width) - 1;
|
|
|
|
return divider_ro_determine_rate(hw, req, NULL, divider->width,
|
|
CLK_DIVIDER_ROUND_CLOSEST, val);
|
|
}
|
|
|
|
static int div_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
|
|
return divider_determine_rate(hw, req, NULL, divider->width,
|
|
CLK_DIVIDER_ROUND_CLOSEST);
|
|
}
|
|
|
|
static int div_set_rate(struct clk_hw *hw, unsigned long rate,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
struct clk_regmap *clkr = ÷r->clkr;
|
|
u32 div;
|
|
|
|
div = divider_get_val(rate, parent_rate, NULL, divider->width,
|
|
CLK_DIVIDER_ROUND_CLOSEST);
|
|
|
|
return regmap_update_bits(clkr->regmap, divider->reg,
|
|
(BIT(divider->width) - 1) << divider->shift,
|
|
div << divider->shift);
|
|
}
|
|
|
|
static unsigned long div_recalc_rate(struct clk_hw *hw,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
struct clk_regmap *clkr = ÷r->clkr;
|
|
u32 div;
|
|
|
|
regmap_read(clkr->regmap, divider->reg, &div);
|
|
div >>= divider->shift;
|
|
div &= BIT(divider->width) - 1;
|
|
|
|
return divider_recalc_rate(hw, parent_rate, div, NULL,
|
|
CLK_DIVIDER_ROUND_CLOSEST, divider->width);
|
|
}
|
|
|
|
const struct clk_ops clk_regmap_div_ops = {
|
|
.determine_rate = div_determine_rate,
|
|
.set_rate = div_set_rate,
|
|
.recalc_rate = div_recalc_rate,
|
|
};
|
|
EXPORT_SYMBOL_GPL(clk_regmap_div_ops);
|
|
|
|
const struct clk_ops clk_regmap_div_ro_ops = {
|
|
.determine_rate = div_ro_determine_rate,
|
|
.recalc_rate = div_recalc_rate,
|
|
};
|
|
EXPORT_SYMBOL_GPL(clk_regmap_div_ro_ops);
|