mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
900b7cc73c
The module_attach test contains subtests which check that unloading a
module while there are BPF programs attached to its functions is not
possible because the module is still referenced.
The problem is that the test calls the generic unload_module() helper
function which is used for module cleanup after test_progs terminate and
tries to wait until all module references are released. This
unnecessarily slows down the module_attach subtests since each
unsuccessful call to unload_module() takes about 1 second.
Introduce try_unload_module() which takes the number of retries as a
parameter. Make unload_module() call it with the currently used amount
of 10000 retries but call it with just 1 retry from module_attach tests
as it is always expected to fail. This speeds up the module_attach()
test significantly.
Before:
# time ./test_progs -t module_attach
[...]
Summary: 1/14 PASSED, 0 SKIPPED, 0 FAILED
real 0m5.011s
user 0m0.293s
sys 0m0.108s
After:
# time ./test_progs -t module_attach
[...]
Summary: 1/14 PASSED, 0 SKIPPED, 0 FAILED
real 0m0.350s
user 0m0.197s
sys 0m0.063s
Signed-off-by: Viktor Malik <vmalik@redhat.com>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Tested-by: Alan Maguire <alan.maguire@oracle.com>
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20260306101628.3822284-1-vmalik@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
64 lines
2.0 KiB
C
64 lines
2.0 KiB
C
/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
|
|
/* Copyright (C) 2020 Facebook, Inc. */
|
|
|
|
#ifndef __TESTING_HELPERS_H
|
|
#define __TESTING_HELPERS_H
|
|
|
|
#include <stdbool.h>
|
|
#include <bpf/bpf.h>
|
|
#include <bpf/libbpf.h>
|
|
#include <time.h>
|
|
|
|
#define __TO_STR(x) #x
|
|
#define TO_STR(x) __TO_STR(x)
|
|
|
|
int parse_num_list(const char *s, bool **set, int *set_len);
|
|
__u32 link_info_prog_id(const struct bpf_link *link, struct bpf_link_info *info);
|
|
int bpf_prog_test_load(const char *file, enum bpf_prog_type type,
|
|
struct bpf_object **pobj, int *prog_fd);
|
|
int bpf_test_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
|
|
size_t insns_cnt, const char *license,
|
|
__u32 kern_version, char *log_buf,
|
|
size_t log_buf_sz);
|
|
|
|
/*
|
|
* below function is exported for testing in prog_test test
|
|
*/
|
|
struct test_filter_set;
|
|
int parse_test_list(const char *s,
|
|
struct test_filter_set *test_set,
|
|
bool is_glob_pattern);
|
|
int parse_test_list_file(const char *path,
|
|
struct test_filter_set *test_set,
|
|
bool is_glob_pattern);
|
|
|
|
__u64 read_perf_max_sample_freq(void);
|
|
int load_bpf_testmod(bool verbose);
|
|
int unload_bpf_testmod(bool verbose);
|
|
int kern_sync_rcu(void);
|
|
int finit_module(int fd, const char *param_values, int flags);
|
|
int delete_module(const char *name, int flags);
|
|
int load_module(const char *path, bool verbose);
|
|
int load_module_params(const char *path, const char *param_values, bool verbose);
|
|
int try_unload_module(const char *name, int retries, bool verbose);
|
|
int unload_module(const char *name, bool verbose);
|
|
|
|
static inline __u64 get_time_ns(void)
|
|
{
|
|
struct timespec t;
|
|
|
|
clock_gettime(CLOCK_MONOTONIC, &t);
|
|
|
|
return (u64)t.tv_sec * 1000000000 + t.tv_nsec;
|
|
}
|
|
|
|
struct bpf_insn;
|
|
/* Request BPF program instructions after all rewrites are applied,
|
|
* e.g. verifier.c:convert_ctx_access() is done.
|
|
*/
|
|
int get_xlated_program(int fd_prog, struct bpf_insn **buf, __u32 *cnt);
|
|
int testing_prog_flags(void);
|
|
bool is_jit_enabled(void);
|
|
|
|
#endif /* __TESTING_HELPERS_H */
|